| Summary: | FILEOPEN An empty line is too tall in the attached DOCX | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Aron Budea <aron.budea> |
| Component: | filters and storage | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | bugzilla, jluth, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 4.0.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=70007 https://bugs.documentfoundation.org/show_bug.cgi?id=127616 https://bugs.documentfoundation.org/show_bug.cgi?id=73238 https://bugs.documentfoundation.org/show_bug.cgi?id=136768 |
||
| Whiteboard: | target:6.2.0 target:6.4.0 target:6.3.3 target:6.2.8 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108760, 108769 | ||
| Attachments: |
Sample DOCX
Screenshot comparing Word and Writer |
||
Created attachment 142500 [details]
Screenshot comparing Word and Writer
Bibisected to the following range using repo /bibisect-43all: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=179a6db61ee30cf776747802f06edeef45fec461..5f91f8a368343d8921a01edb7359cd300892f09d Reproduced in Version: 6.1.0.0.beta1+ Build ID: b57819201ff89bbde14b4df8c02a0eb4bea2c2bb CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded The offending commit is https://cgit.freedesktop.org/libreoffice/core/commit/?id=355d25eac764713f4d52eac801ade6e2ff1deab0 n#779627: added quite some compat options from the ww8 filter on writerfilter Specifically xSettings->setPropertyValue( "IgnoreTabsAndBlanksForLineCalculation", uno::makeAny( sal_True ) ); proposed fix https://gerrit.libreoffice.org/57991 I used Word2013 to save the file as RTF, but it acts differently (without showing this bug) and seems unaffected by this patch. (In reply to Justin L from comment #4) > The offending commit is > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=355d25eac764713f4d52eac801ade6e2ff1deab0 > n#779627: added quite some compat options from the ww8 filter on writerfilter > > Specifically xSettings->setPropertyValue( > "IgnoreTabsAndBlanksForLineCalculation", uno::makeAny( sal_True ) ); Same commit as in bug 70007, are they related ? *** Bug 70007 has been marked as a duplicate of this bug. *** Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=49ddaad2f3ba4e17e1e41e94824fb94468d2b680 tdf#117988 writerfilter: IgnoreTabsAndBlanksForLineCalculation It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 6.2.0.0.alpha0+ Build ID: 72b099d279e7096d41a04fe8c0dd493a5fc18a33 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded @Justin L, thanks for fixing this!! Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/202bee1a819de7b1e8c75dd863c4154f66419400 Revert "tdf#117988 writerfilter: IgnoreTabsAndBlanksForLineCalculation" It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Reverting as far back as I can go since I did not have the proper fix, as proved by bug 127617. This probably is a duplicate of bug 127368. Since that is a clean report, I'll mark this one as a duplicate. The third (empty) paragraph has this definition: <w:pPr> <w:pStyle w:val="BodyText"/> <w:rPr> <w:sz w:val="16"/> </w:rPr> </w:pPr> so, the paragraph char property size of 16pt should override BodyText style's 48pt. *** This bug has been marked as a duplicate of bug 127368 *** Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/b0c5bc47d0d170df1384dd48cee9291ce6044083 Revert "tdf#117988 writerfilter: IgnoreTabsAndBlanksForLineCalculation" It will be available in 6.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/commit/35d3f2bdc820bce8bfb98cfe942e9e91a338973b Revert "tdf#117988 writerfilter: IgnoreTabsAndBlanksForLineCalculation" It will be available in 6.2.8. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 142499 [details] Sample DOCX Open the attached DOCX, created in Word. The third (empty) line shows as huge, even though the font size is supposed to be 8 pt. Observed using LO 6.1beta1 & 4.0.0.3 / Windows 7. Size is fine in 3.5.0.3. => regression