| Summary: | Crash when closing the color picker dialog if it was opened from the overflow toolbar popup ( Hangs on Win ) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Maxim Monastirsky <momonasmon> |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | caolan.mcnamara, serval2412, xiscofauli |
| Priority: | highest | Keywords: | bibisected, bisected, haveBacktrace, regression |
| Version: | 6.1.0.0.alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.2.0 target:6.1.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | bt with debug symbols | ||
|
Description
Maxim Monastirsky
2018-06-19 19:37:24 UTC
Regression introduced by: author Caolán McNamara <caolanm@redhat.com> 2018-05-08 12:35:19 +0100 committer Caolán McNamara <caolanm@redhat.com> 2018-05-08 16:05:41 +0200 commit bfcf57de81ddd5ed8544ff2ede23bd8428f0c0ce (patch) tree a6d3a528b2ec1e5f41764984d16675df3d352621 parent b68daa69739e83095c023b683234d344d0fa02c8 (diff) Resolves: tdf#117470 reuse parent window of colorwindow... as parent of color selector window Bisected with: bibisect-linux64-6.1 Adding Cc: to Caolán McNamara Created attachment 142979 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today, I could reproduce this.
I attached a bt with symbols.
I've just tested this problem on Win and LibreOffice hangs trying to display the custom colour dialog. Also caused by the same commit... I'm gonna give a new try after my day time job because I'll got the commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=b15244d526c285cd109f7195855409f698d0cdc0 in my local build. Perhaps this commit may help. I confirm I don't reproduce this with master sources updated today ( eb678c01d35a485b9f79009c126e296d9e811d36) Let's put this one to FIXED. If someone still reproduces this, don't hesitate to reopen this tracker. Verified in Version: 6.2.0.0.alpha0+ Build ID: b25f59094794eb72eefdbbbca8ac69eb325120c8 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded Yes, this seems fixed with gtk3, but still hangs in Windows (as in comment 3) and in gtk2. Also, at least with gtk2 if I switch the focus to another application and back, it crashes. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac9db25da2d78f8ecc2ce68ad622cc6012972494 Resolves: tdf#118251 decide what parent colorpicker should have... It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=565f5d40c83ca30fcd2f28359e0f1df0b4cbb9fe&h=libreoffice-6-1 Resolves: tdf#118251 decide what parent colorpicker should have... It will be available in 6.1.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fully fixed now, thanks Caolán! |