Bug 118303

Summary: Wrong converting of the Vendor-String
Product: LibreOffice Reporter: Juergen Funk (CIB) <juergen.funk_ml>
Component: LibreOfficeAssignee: Juergen Funk (CIB) <juergen.funk_ml>
Status: RESOLVED FIXED    
Severity: normal CC: michael.stahl, thb, xiscofauli
Priority: medium    
Version: 6.2.0.0.alpha0+   
Hardware: All   
OS: Windows (All)   
Whiteboard: target:6.2.0 target:6.1.0.1
Crash report or crash signature: Regression By:

Description Juergen Funk (CIB) 2018-06-21 13:14:49 UTC
When the vondor-string the german char ü contain, then this convert to ansi (ü) and then back to UTF-8 as ü in the version.ini file
With the make version 3.82 the converting is okay, but with version 4.x it is wrong
Comment 1 Michael Stahl (allotropia) 2018-06-21 13:23:38 UTC
this problem was introduced by switching to native Win32 make:

* Makefiles don't have any metadata to specify the encoding
* all of the Cygwin tools in the build system assume everything is UTF-8 encoded
* Win32 make calls CreateProcessA(), which converts the arguments from some so-called "ANSI" codepage to UCS-2

hence in commands invoked from make, the UTF-8 string is erroneously interpreted as latin1 and converted to UCS-2.
Comment 2 Commit Notification 2018-06-25 10:59:04 UTC
Juergen Funk committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7f1f1f53206c85fb0e2290e5fb2e20dcedfa2610

tdf#118303 - Wrong converting of the Vendor-String

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2018-06-26 09:34:51 UTC
Juergen Funk committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e6b7948503c276bdfe45a5ee6277ad8edbde6ebe&h=libreoffice-6-1

tdf#118303 - Wrong converting of the Vendor-String

It will be available in 6.1.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Michael Stahl (allotropia) 2018-07-09 13:10:28 UTC
fixed on master and libreoffice-6-1, thanks Juergen!