| Summary: | The Track changes toolbar is appended to the Table toolbar, should be stacked and pinned left | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Gabor Kelemen (allotropia) <kelemeng> |
| Component: | Writer | Assignee: | Gabor Kelemen (allotropia) <kelemeng> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, cno, dgp-mail, heiko.tietze, kelemeng, libreoffice, vsfoote, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 5.3 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108816 | ||
| Attachments: |
Example document with tracked changes in a table
Track changes toolbar with a changed paragraph. Track changes toolbar and Table toolbar Track changes toolbar and Bullets/Numbering toolbar Screenshot of proposed patch |
||
|
Description
Gabor Kelemen (allotropia)
2018-08-09 09:52:55 UTC
Created attachment 144055 [details]
Track changes toolbar with a changed paragraph.
Click Next Change here a few times...
Created attachment 144056 [details]
Track changes toolbar and Table toolbar
...now click once more carelessly and you add a column right of the current change.
Created attachment 144057 [details]
Track changes toolbar and Bullets/Numbering toolbar
The Bullets/Numbering toolbar however does not interfere with the workflow.
+1 I changed status to NEW. It is clear, that design team can decide WONTFIX. Agree, the Table toolbar should be keep in its position. The Track Changes toolbar should be stacked above it (or below it) and pinned left, rather than being appended to Table toolbar. +1 Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=6f8f053a22a9010b50e6142443909bd31d5501df author Caolán McNamara <caolanm@redhat.com> 2016-11-21 14:33:31 +0000 committer Caolán McNamara <caolanm@redhat.com> 2016-11-21 14:54:58 +0000 commit 6f8f053a22a9010b50e6142443909bd31d5501df (patch) tree bfa9a22031e1b0f111b11b489d4aaf6f4c8a1030 parent 66ccfcd2908445b8194c364c89778056374b02af (diff) set the search toolbar so it doesn't move around wrt table/numbering toolbars Bisected with: bibisect-linux-64-5.3 Adding Cc: to Caolán McNamara Created attachment 149587 [details] Screenshot of proposed patch With my patch this is how the bottom docked toolbars look. When one creates a change tracked numbering in a table cell and shows the Search toolbar, all four appear on top of each other. https://gerrit.libreoffice.org/68365 Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0631a91c1dafbd754a8d2bc2ccae03b547754cbd%5E%21 tdf#119167 Show Table toolbar above Track Changes toolbar It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Gabor Kelemen from comment #9) > When one creates a change tracked numbering in a table cell and shows the > Search toolbar, all four appear on top of each other. Pushed to master. At least it wont jump too much but the pile is quite large. Let's see if users accept it. I don't get the result, that is shown in attachment 149587 [details]. Table toolbar is placed left of the track changes toolbar. This is better than before, but I hope that an improvement is still possible. Shall I reopen the bug? Version: 6.4.0.0.alpha0+ (x64) Build ID: 2f2f4767089512c34514896bc37823f9310e9dd4 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-07-10_02:13:57 Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded It looks perfect to me with Version: 7.1.0.0.alpha0+ (x64) Build ID: <buildversion> CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: threaded => VERIFIED FIXED |