| Summary: | Freeze if Option “Edit document properties before saving” is Enabled | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Harald Koester <harald.koester> |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | aron.budea, caolan.mcnamara, hcastro, jluth, kendy, oliver.brinzing, vsfoote, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, regression |
| Version: | 6.1.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=117895 https://bugs.documentfoundation.org/show_bug.cgi?id=120343 |
||
| Whiteboard: | target:7.3.0 target:7.2.3 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107943, 108747, 132243 | ||
|
Description
Harald Koester
2018-08-10 19:40:50 UTC
Reproduced in Version: 6.2.0.0.alpha0+ Build ID: 18e20676024baecaf5719139f80f053f5f1e784a CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=0950917b9514069e8dbf92b9c0fbd44b492a7cd1 author Henry Castro <hcastro@collabora.com> 2018-03-01 16:11:44 -0400 committer Henry Castro <hcastro@collabora.com> 2018-03-02 19:55:01 +0100 commit 0950917b9514069e8dbf92b9c0fbd44b492a7cd1 (patch) tree fa450d498c714295791e2f0a29d1bce87a52dd4e parent e802e960f8f7343eec1a14eba70b7affc6298968 (diff) lokdialog: convert the dialog File -> Properties... to async exec Bisected with: bibisect-win32-6.1 Adding Cc: to Henry Castro Bug still exists in version 6.2.1 (64 bit) with Win10. reproducible with: Version: 7.0.0.0.alpha0+ (x64) Build ID: a6192281a04c20bc57b1ffa4f6645ca639d5b1a4 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded crashes with an unsatisfied query for interface of type com.sun.star.document.XDocumentPropertiesSupplier I guess, the root cause for this bug, is that the document is already closed. repro 7.2+ Why hasn't Collabora responded at all to this crash report? A proof of concept patch is at http://gerrit.libreoffice.org/c/core/+/109412 (In reply to Justin L from comment #6) > A proof of concept patch is at http://gerrit.libreoffice.org/c/core/+/109412 I'm adding Caolán to the loop. He fixed some async dialog issues in the past OK - but note that I have already asked Ashod to review and he is a pretty heavy hitter all by himself. (In reply to Xisco Faulí from comment #7) > I'm adding Caolán to the loop. He fixed some async dialog issues in the past Still no useful response from Collabora one month later, so Caolán won't be stepping on anyone's toes if he decides to become interested. I abandoned my PoC, and will only be an interested observer on the sidelines. still repro 7.3+. Hi Caolán, Since you fixed bug 120343, I thought you might be interested in this issue fallback proposal to just ignore the doc properties request is at http://gerrit.libreoffice.org/c/core/+/123870 tdf#119206 I think on the close path that running this async can't really be made work without way way more work than anyone is going to put in. So I'll take this and... undo fix for tdf#120343 and undo fix for tdf#117895 and instead rearrange things to that file, properties continues to be run async, but when the properties dialog is launched from close its run sync Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/39994c43bf6610f2a8fde55f54ed9a7e279935b4 Resolves: tdf#119206 run properties sync when launched during save It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. well, that should make it not fail horribly. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/9e52f282200dd3cd02fe3aa1b5566f16a470f7e9 Resolves: tdf#119206 run properties sync when launched during save It will be available in 7.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/01cbdcc6dd0cf575997e9899496115ac41ab4be1 tdf#119206: sw: Add UItest It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |