| Summary: | FILEOPEN: DOC: the first letter of a link URL to a picture get missing | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | kivi <kiv> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | buzea.bogdan, caolan.mcnamara, dgp-mail, quikee, serval2412, telesto, vmiklos, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 5.4.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.2.0 target:6.1.3 target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Demo files for first letter of a URL missing | ||
|
Description
kivi
2018-09-20 08:34:22 UTC
kivi: any better with LO version 6.1.1? (In reply to kivi from comment #0) > Created attachment 145053 [details] > Wnen create a document in Writer and put a URL as a link to a picture there, > then save and close the document and then open it again, the first letter of > the URL get missing. The files in your attachment are doc-files. But you said, you create a document in writer. Does it only happen, if you save it as doc(x), or also, if you save it as odt? The same problem exists also in LibreOffice 6.1 This problem is not available with odt files. When I have same demo file as odt and save it as docx the commented link completely disappeared in the docx. Also if I try the same file but in docx,after every save, close and reopen the needed link get missing. Could you make a video showing how letters are lost? And how you reproduce this bug? I think I can confirm this issue. How I reproduce it: * Create new writer document * Menu: Insert > Image ... * Chose image, in my case a simple jpg file * Select the image (click it so it has the focus) * ctrl+k or Menu: Insert > Hyperlink... - URL: https://www.libreoffice.org * Click "OK" button * Save the document as doc (Microsoft binary format) and close the doc * Open the doc again * Verify the URL by selecting the image and typing ctrl+k Expected result in the "URL" field: https://www.libreoffice.org Actual result in the "URL" field: tps://www.libreoffice.org/%00 Doing the same with docx (Microsoft XML format): Expected result in the "URL" field: https://www.libreoffice.org Actual result in the "URL" field: empty I'm using: Version: 6.1.1.2 Build ID: 10(Build:2) CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: gtk3; Locale: en-US (en_CH.UTF-8); Calc: group threaded (In reply to Nicolas Christener from comment #5) > I think I can confirm this issue. How I reproduce it: Great, nice way to reproduce. I can reproduce on: Version: 6.2.0.0.alpha0+ Build ID: 67c8049a3abcaf9aa692fc9ba768b5db9fbb2f05 CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-09-25_20:09:22 Locale: ro-RO (ro_RO.UTF-8); Calc: threaded I use 6.2 to create the .doc file and also to open the document after saving... The link appear like tp://link/%00 On pc Debian x86-64 with master sources updated today, I could reproduce this. Indeed I don't reproduce this with odt. Miklos: thought you might be interested in this one since it seems related to doc and docx filters This is an importing problem... Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9b77f8142bf665a47c3a179e3fe3f82623a99f8a author Caolán McNamara <caolanm@redhat.com> 2017-04-06 15:08:45 +0100 committer Caolán McNamara <caolanm@redhat.com> 2017-04-07 09:02:45 +0000 commit 9b77f8142bf665a47c3a179e3fe3f82623a99f8a (patch) tree 6aee5ab0ec475499fa20f0485bdcb16853b5a79f parent 60aac84fc83ca6d527d06cf4ce031d7ef5ffee48 (diff) ditch ReadRawUniString This thing is defined by MS-OSHARED, there FWIW, the 8 bit encoding is "ANSI", which is somewhat useless, use the same GetCharSetFromLanguage() attempt we use elsewhere when that problem arises Bisected with: bibisect-linux-64-5.4 Adding Cc: to Caolán McNamara Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=99fa8d59f8cc3f06ce4fbe6b5ec834e9e30ae3b4 Resolves: tdf#120003 missing prefix to link url in .doc import It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 6.2.0.0.alpha0+ Build ID: 5fb66ae5595b7435e8954df31473fad15a74b8c2 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-US (ca_ES.UTF-8); Calc: threaded Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=faf048080124a4e1c9fcb4637fa9541921c758bd&h=libreoffice-6-1 Resolves: tdf#120003 missing prefix to link url in .doc import It will be available in 6.1.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e40c944e8e654228e1893fc1bded8e1bded41ee7&h=libreoffice-6-1-3 Resolves: tdf#120003 missing prefix to link url in .doc import It will be available in 6.1.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. homeboy445 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f343ad6d8a78798814c9d38261043619b4e2b487 tdf#120003: sw_ww8export3: Add unittest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |