Bug 120056

Summary: Weird behavior of Wrap dialog when changing wrap type by arrow keys ( not gtk3 )
Product: LibreOffice Reporter: Tamás Zolnai <zolnaitamas2000>
Component: WriterAssignee: Caolán McNamara <caolan.mcnamara>
Status: VERIFIED FIXED    
Severity: normal CC: caolan.mcnamara, xiscofauli
Priority: medium Keywords: bibisected, bisected, regression
Version: 6.2.0.0.alpha0+   
Hardware: All   
OS: Windows (All)   
Whiteboard: target:6.2.0
Crash report or crash signature: Regression By:
Attachments: A video showing how selection moves when I'm pushing right arrow key

Description Tamás Zolnai 2018-09-22 15:35:33 UTC 
Description:
On Wrap dialog we have six type of wraping (e.g. None, Before, After, etc..). When I try to change the wrap type by keybord using arrow keys the selection change is wierd. I pushing right arrow key, but focus move down, right, left-up, etc, which does not make sense.
It seems a WIN only bug, since with Linux (openSuse) I don't see this issue. There it work perfectly.

Steps to Reproduce:
1. Open Writer
2. Insert a shape
3. Right click on the shape -> Wrap -> Edit
4. Select one wrap type by mouse and then move the selection using arrow keys

Actual Results:
Movement of the selection is unexpected, not moving the direction what we select with the arrow key.

Expected Results:
When pushing left the selection should move left and similar to other directions.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Tamás Zolnai 2018-09-22 15:36:36 UTC 
Created attachment 145112 [details]
A video showing how selection moves when I'm pushing right arrow key
Comment 2 Xisco Faulí 2018-09-22 17:56:51 UTC 
I can reproduce it in

Version: 6.2.0.0.alpha0+
Build ID: 66232248ff55639052ddb76918d555e21dc9c46b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

and gtk but not with gtk3
Comment 3 Xisco Faulí 2018-09-22 18:07:20 UTC 
Recent regression.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f6ab12d5dae1212b0ad4e82ca3325f3dd4c974b6

author	Caolán McNamara <caolanm@redhat.com>	2018-09-20 14:24:55 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2018-09-20 18:13:05 +0200
commit f6ab12d5dae1212b0ad4e82ca3325f3dd4c974b6 (patch)
tree 921d7e9de1fe7e323543489f85cd0f78f664057d
parent 11a229c0094979b4980d8e3be8a8a7db60d01be7 (diff)
weld SwWrapDlg

Bisected with: bibisect-linux64-6.2

Adding Cc: to Caolán McNamara
Comment 4 Caolán McNamara 2018-09-22 19:24:24 UTC 
just need to reorder them in the xml to the right order for the vcl parser
Comment 5 Commit Notification 2018-09-23 20:28:44 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=40287a71f8be03ba2fefc8500509bb37c74cd5b4

tdf#120056 reorder radiobuttons elements into desired logical order

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Xisco Faulí 2018-09-25 08:37:24 UTC 
Verified in

Version: 6.2.0.0.alpha0+
Build ID: daf44342ca82c5b0e79da88b7f9dbf28f6d43a8b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

@Caolán, thanks for fixing this!
Comment 7 Xisco Faulí 2018-09-25 08:38:54 UTC 
Verified in

Version: 6.2.0.0.alpha0+
Build ID: daf44342ca82c5b0e79da88b7f9dbf28f6d43a8b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

as well