Bug 120093

Summary:	Limit the choice of Emphasis custom animations when the selected object is an image
Product:	LibreOffice	Reporter:	Buovjaga <ilmari.lauhakangas>
Component:	Impress	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED WORKSFORME
Severity:	enhancement	CC:	diogogsousa, stephane.guillou, xiscofauli
Priority:	low
Version:	Inherited From OOo
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=71169
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	109362
Attachments:	test ODP with many animations on raster images

Description Buovjaga 2018-09-23 17:01:20 UTC

Quoting from bug 119543:
(In reply to Diogo G. Sousa from comment #0)
> Description:
> Many emphasis animations don't do anything.  Where is the list:
> 
> 1. Change fill color
> 2. Change line color
> 3. Color blend
> 4. Complementary color
> 5. Complementary color 2
> 6. Contrasting color
> 7. Darken
> 8. Desaturate
> 9. Lighten
> 10. Blast (works only with hardware acceleration off)
> 11. Blink
> 12. Flicker (works only with hardware acceleration off)
> 13. Teeter (works only with hardware acceleration off)

At least 1-6 only make sense for LibreOffice shapes.
7-9 might be made to work in theory.
10-13 should work even for images, so brokenness is a bug.

Comment 1 Stéphane Guillou (stragu) 2024-02-27 15:17:11 UTC

Update with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

> 1. Change fill color
Useful if using a raster image with transparency and an Area Fill
> 2. Change line color
Useful if Line property applied to image (i.e. a border/frame)
> 3. Color blend
> 4. Complementary color
> 5. Complementary color 2
> 6. Contrasting color
> 7. Darken
> 8. Desaturate
> 9. Lighten
3 to 9 all have an effect if there is text attached to the image
> 10. Blast (works only with hardware acceleration off)
> 11. Blink
> 12. Flicker (works only with hardware acceleration off)
> 13. Teeter (works only with hardware acceleration off)
10 to 13 all have an effect (be it only on text, or on whole picture), with hardware acceleration turned on.

So I don't think there's a case for limiting the choice of animations here, and I am closing as "works for me". If there are issues remaining (and I'm sure there are some, as we're talking about animations!), or even if I missed something in there, let's open more specific, actionable reports.

(In reply to Buovjaga from comment #0)
> 7-9 might be made to work in theory.
This makes perfect sense, I think it should be opened as a separate enhancement request.

Comment 2 Stéphane Guillou (stragu) 2024-02-27 15:17:43 UTC

Created attachment 192827 [details]
test ODP with many animations on raster images

Comment 3 Stéphane Guillou (stragu) 2024-02-27 15:25:48 UTC

(In reply to Stéphane Guillou (stragu) from comment #1)
> (In reply to Buovjaga from comment #0)
> > 7-9 might be made to work in theory.
> This makes perfect sense, I think it should be opened as a separate
> enhancement request.
Ah, kind of already tracked in bug 71169.