| Summary: | Wrong wrap optimal icon in Karasa Jaga, elementary, Breeze/Sifr, Tango/Galaxy and Colibre | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Rizal Muttaqin <rizmut> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | heiko.tietze, kainz.a, serval2412, xiscofauli |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.2.0 target:6.3.0 target:6.2.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107139, 117497, 120946, 120949, 75256, 108160 | ||
| Attachments: |
Wrap optimal in Breeze icon
Wrap optimal in Colibre icon Wrap optimal in elementary icon Wrap optimal in Karasa Jaga icon Wrap optimal in Tango (inherited from Galaxy) icon |
||
|
Description
Rizal Muttaqin
2018-09-25 05:12:32 UTC
Created attachment 145148 [details]
Wrap optimal in Breeze icon
Created attachment 145149 [details]
Wrap optimal in Colibre icon
Created attachment 145150 [details]
Wrap optimal in elementary icon
Created attachment 145151 [details]
Wrap optimal in Karasa Jaga icon
Created attachment 145152 [details]
Wrap optimal in Tango (inherited from Galaxy) icon
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=46d781553e0ab0b55363d9ec57a6487b0f7caa26 tdf#120108 KJ: Update decrease indentation & wrap icon; add LICENSE It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. First commit about Karasa is https://cgit.freedesktop.org/libreoffice/core/commit/?id=a06954bf5b100c9433b4e1dbcdcf8ab2df2763a1, 2018-05-22. So it's not inherited from OOo, it's only from 6.2.0 If so, this one should be put to fixed, shouldn't it? (In reply to Julien Nabet from comment #7) > First commit about Karasa is > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=a06954bf5b100c9433b4e1dbcdcf8ab2df2763a1, 2018-05-22. > So it's not inherited from OOo, it's only from 6.2.0 > If so, this one should be put to fixed, shouldn't it? Karasa Jaga in the first place is always follow Galaxy as the reference. So, this bug actually happen in Galaxy, inheritted from Ooo. Another thing that it affect other icons too since they follow also Galaxy. (In reply to Rizal Muttaqin from comment #8) > ... > Karasa Jaga in the first place is always follow Galaxy as the reference. So, > this bug actually happen in Galaxy, inheritted from Ooo. Another thing that > it affect other icons too since they follow also Galaxy. Thank you for your quick feedback, I understand better now. So it needs more patches for other themes + backports at least (only?) for 6.1 branch. I understand the need code-wise that a new variable is needed for this icon. And design-wise that fancy icons have to be created for all themes. Would close this ticket as fixed. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7f16835c10435ddafdfe05921eac9b89e488ab8e tdf#120065 and tdf#120108, Fix wrap elementary icons It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. A polite ping to Rizal Muttaqin: Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing? Thanks (In reply to Xisco Faulí from comment #12) > A polite ping to Rizal Muttaqin: > Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? > Otherwise, Could you please explain what's missing? > Thanks Already fixed for Karasa Jaga and elementary, while other icons need to be changed also. CC Andreas Kainz colibre and breeze fix is in gerrit andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/dd2de0c07f8ed5ebe11412902c011519b5c50be7%5E%21 tdf#120108 Wrong wrap optimal icon It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. andreas kainz committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/48aab2c9e930b138106bdcc765021ae2dbbed779%5E%21 tdf#120108 Wrong wrap optimal icon It will be available in 6.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |