Bug 120207

Summary:	Change the default font choice order for LibreOffice Calc in Hebrew
Product:	LibreOffice	Reporter:	Eyal Rozenberg <eyalroz1>
Component:	Calc	Assignee:	Eyal Rozenberg <eyalroz1>
Status:	RESOLVED FIXED
Severity:	minor	CC:	ilmari.lauhakangas, vsfoote
Priority:	medium
Version:	6.2.0.0.alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=113538
Whiteboard:	target:7.2.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	112812
Attachments:	Arial, Alef, Liberation Sans and Nachlieli at 10pt

Description Eyal Rozenberg 2018-09-30 09:08:05 UTC

Description:
Calc use is a lot more on-screen, and at lower size in points (10 instead of 12 on my Linux machine).

Currently, the font order is:

Nachlieli CLM;Alef;Noto Sans Hebrew;Liberation Sans;Arial;Arial Hebrew;Lucida Sans Unicode;Lucida Grande;Arial Unicode MS

according to: 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a2158c6ca2ba831665019827889f01e98dc93394

But Nachlieli CLM has relatively low readability, IMO, in small font sizes, and Alef is not much tter. I therefore suggest that the order become:

Liberation Sans;Noto Sans Hebrew;Nachlieli CLM;Alef;Arial;Arial Hebrew;Lucida Sans Unicode;Lucida Grande;Arial Unicode MS

Or alterntvely:

Arial;Liberation Sans;Noto Sans Hebrew;Nachlieli CLM;Alef;Arial Hebrew;Lucida Sans Unicode;Lucida Grande;Arial Unicode MS

(Note that I havent' sctually looked at the last three on the list recently.

Steps to Reproduce:
Type in some Hebrew text along a column.

Actual Results:
Text comes out in Nachlieli CLM, and is not very readoable

Expected Results:
Text comes out in a more readable font


Reproducible: Always


User Profile Reset: No



Additional Info:

Comment 1 Eyal Rozenberg 2018-10-09 10:52:51 UTC

Created attachment 145519 [details]
Arial, Alef, Liberation Sans and Nachlieli at 10pt

Some have raised the question of whether Alef should not be used before Liberation Sans. Well, no...

Attached is a screenshot with the three fonts used for the same content - a part of an LO Calc chart. Note that Liberation Sans' readability advantage is a bit of a "cheat" since its glyph width and height at 10pt are larger than Arial's and Alef's.

Nachlieli comes in third IMHO, but it's not as readable as Liberation Sans. (It's about as readable even as Liberation Sans at 9pt, maybe less; but that would definitely be an unfair comparison).

Comment 2 Buovjaga 2018-10-27 14:17:11 UTC

Ok. Feel free to propose a patch https://wiki.documentfoundation.org/Development/gerrit

Comment 3 QA Administrators 2019-10-28 03:29:30 UTC Comment hidden (obsolete)

Dear Eyal Rozenberg,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

Comment 4 Eyal Rozenberg 2019-10-28 05:59:38 UTC

(In reply to Buovjaga from comment #2)
> Ok. Feel free to propose a patch
> https://wiki.documentfoundation.org/Development/gerrit

I actually need to get around to proposing that patch. It's just that I've never done anything like that for LO before; I don't have a checked out copy of the sources.

Anyway, this bug should not be auto-closed...

Comment 5 Buovjaga 2019-10-28 06:20:55 UTC

(In reply to Eyal Rozenberg from comment #4)
> (In reply to Buovjaga from comment #2)
> > Ok. Feel free to propose a patch
> > https://wiki.documentfoundation.org/Development/gerrit
> 
> I actually need to get around to proposing that patch. It's just that I've
> never done anything like that for LO before; I don't have a checked out copy
> of the sources.
> 
> Anyway, this bug should not be auto-closed...

To avoid cloning the source, you can also edit directly in gerrit: https://wiki.documentfoundation.org/Documentation/GerritEditing

Comment 6 Eyal Rozenberg 2021-02-13 09:35:59 UTC

(In reply to Buovjaga from comment #5)

So, I've finally gotten around to doing this. Now I need reviewers for the patch...

https://gerrit.libreoffice.org/c/core/+/110790

Plus, I need more opinions on the order of fonts I've chosen.

Comment 7 Commit Notification 2021-02-16 14:16:18 UTC

Eyal Rozenberg committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/21da461f374357198bafaea02e28d24de02c6772

tdf#120207 Change the order of default Hebrew font choice for spreadsheets

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.