| Summary: | branch crashes in bibliography database -> Data -> autofilter | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Hussam Al-Tayeb <ht990332> |
| Component: | LibreOffice | Assignee: | Julien Nabet <serval2412> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | kainz.a, serval2412, xiscofauli |
| Priority: | highest | Keywords: | bibisected, bisected, haveBacktrace, regression |
| Version: | 6.1.2.1 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://crashreport.libreoffice.org/stats/signature/cppu::_copyConstructAny(_uno_Any%20*,void%20*,_typelib_TypeDescriptionReference%20*,_typelib_TypeDescription%20*,void%20(*)(void%20*),_uno_Mapping%20*) | ||
| Whiteboard: | target:6.2.0 target:6.1.3 | ||
| Crash report or crash signature: | ["cppu::_copyConstructAny(_uno_Any *,void *,_typelib_TypeDescriptionReference *,_typelib_TypeDescription *,void (*)(void *),_uno_Mapping *)"] | Regression By: | |
| Attachments: |
bt with debug symbols
bt from toolbar when it's ok |
||
|
Description
Hussam Al-Tayeb
2018-10-04 15:58:02 UTC
Same thing with last build from https://dev-builds.libreoffice.org/daily/master/Linux-archive-x86_64@80-updater/current/ So, the menubar 'data' was added in https://cgit.freedesktop.org/libreoffice/core/commit/?id=6cc88407acd148982ba05a9a52e390225449c031 So, it only crashes when calling autofilter from the menu, not when doing it from the toolbar... @Andreas, Do you have more insight of what is going on ? Hi, I tested libo-61-64~2018-10-04_04.40.26_LibreOfficeDev_6.1.3.0.0_Win_x64.msi and there was no crash and on master libo crash. libo-61-64~2018-10-04_04.40.26_LibreOfficeDev_6.1.3.0.0_Win_x64.msi -> no crash libo-master64~2018-10-03_23.04.03_LibreOfficeDev_6.2.0.0.alpha0_Win_x64.msi -> crash As I saw in the patch https://cgit.freedesktop.org/libreoffice/core/commit/?id=6cc88407acd148982ba05a9a52e390225449c031 .uno:Bib/autoFilter was included to the menubar which wasn't available before. The command is from the toolbar.ui file, maybe this command doesn't work in the menubar. conclusio: ---------- .uno:Bib/autoFilter command from toolbar.ui was added to menubar.xml but maybe the command didn't work (out of the box) in the menubar. suggestion: ----------- remove .uno:Bib/autoFilter from the menubar.xml file cause it wasn't there before the patch. > suggestion:
> -----------
> remove .uno:Bib/autoFilter from the menubar.xml file cause it wasn't there
> before the patch.
The question is, why was it added in the first place ? is there any reasoning behind the decision ?
Because its available in the toolbar and there is no reason (exclude) it didnt work to have it not in the menubar the other filter actions are also available in the menubar. Created attachment 145421 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today + enable-dbgutil + gtk3, I could reproduce this.
(In reply to andreas_k from comment #6) > Because its available in the toolbar and there is no reason (exclude) it > didnt work to have it not in the menubar the other filter actions are also > available in the menubar. Why not but how menu Data/Autofilter should retrieve "queryfield" and "querytext" values? The toolbar equivalent retrieves these from extensions/source/bibliography/toolbar.cxx#484 by retrieving "Search Key" for "querytext" value and shows a list to select "queryfield" value. Should it open a new dialog containing the list of fields and a textbox for querytext? Created attachment 145453 [details]
bt from toolbar when it's ok
I added the contents of args in the bt.
$1 = uno::Sequence of length 2 = {{Name = "QueryText", Handle = 0, Value = uno::Any("string": "gris"),
State = com::sun::star::beans::PropertyState::PropertyState_DIRECT_VALUE}, {Name = "QueryField", Handle = 0, Value = uno::Any("string": "Author"),
State = com::sun::star::beans::PropertyState::PropertyState_DIRECT_VALUE}}
Has there been a decision yet on how to handle this? For now, I've edited out the menu entry in my local 6-1 build as per comment #4. I submitted a patch to remove the entry, see https://gerrit.libreoffice.org/#/c/61558/ Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cc6d591e1c4202afdbc30a76fd56d66b7547fa34 tdf#120318: remove autofilter for the moment It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5012a1b0e60416c3397b75d42c2a8eaef1500bdc&h=libreoffice-6-1 tdf#120318: remove autofilter for the moment It will be available in 6.1.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The crash is fixed. Now I let people create an enhancement to implement the feature describing what's expected (synchronisation of params between toolbar and menu) Verified in Version: 6.2.0.0.alpha0+ Build ID: 87e3539d69626780c6d7531b725dd0d64c69e6d8 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded @Julien, Thanks for fixing this! |