| Summary: | Add @NonNull annotation to out parameters in java interfaces generated by javamaker | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | straub |
| Component: | sdk | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | noelgrandin, xiscofauli |
| Priority: | medium | ||
| Version: | 6.1.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
Hello, Would you like to work on this issue? You can submit your patch to gerrit ( https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch ) and core developers will review it... (In reply to Xisco Faulí from comment #1) > Hello, > Would you like to work on this issue? > You can submit your patch to gerrit ( > https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch ) and > core developers will review it... Any update? OTOH, we could make this issue an easyhack with your help and mentor newcomers to work on this issue... @Noel, I would like to hear your opinion on this, do you think it can be turned into an easyhack ? @xisco, probably not, this will require some kind of compatibility work, because adding those things to the interfaces will add another library requirement to the Java UDK which means it's an ABI change (In reply to Noel Grandin from comment #4) > @xisco, probably not, this will require some kind of compatibility work, > because adding those things to the interfaces will add another library > requirement to the Java UDK which means it's an ABI change Hi Noel, Thanks for replying. I think we can close it as RESOLVED WONTFIX then. |
Java interfaces generated by javamaker doesn't seem to use the @NonNull annotation for out parameters. When calling such a method with a null argument where an out parameter is expected, the java uno bridge will terminate with an exception triggered by the following code in urp.java (because args[i] == null). if (argTypes != null) { for (int i = 0; i < argTypes.length; ++i) { if (argTypes[i] != null) { Array.set( args[i], 0, unmarshal.readValue( argTypes[i].getComponentType())); When adding @NonNull to such out arguments, java would prevent the caller to accidentally pass null. To make this method more safe, I'd suggest to also add a try/catch around the Array.set(...) call, which would return an exception to the caller.