| Summary: | Performance regression enabling automatic update of external links | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Xisco Faulí <xiscofauli> |
| Component: | Calc | Assignee: | Dennis Francis <dennisfrancis.in> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | aron.budea, dennisfrancis.in, himajin100000, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, perf, regression |
| Version: | 6.2.0.0.alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=121386 https://bugs.documentfoundation.org/show_bug.cgi?id=127024 |
||
| Whiteboard: | target:6.3.0 target:6.2.1 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Xisco Faulí
2018-11-13 13:27:20 UTC
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=12782fc917bcdc1c119bda675fc27f77887498e0 author Dennis Francis <dennis.francis@collabora.co.uk> 2018-06-12 15:04:04 +0530 committer Dennis Francis <dennis.francis@collabora.co.uk> 2018-06-21 15:04:11 +0200 commit 12782fc917bcdc1c119bda675fc27f77887498e0 (patch) tree d0d990355644b71d4d8333fc7ffe5adbf3f1ab2e parent 6b496d6a0f8b9de38fbf6721796104496d927db3 (diff) Do dependency computation checks for OpenCL and... Bisected with: bibisect-linux64-6.2 Adding Cc: to Dennis Francis confirm for Version: 6.2.0.0.alpha1+ Build ID: a20a2d7e0d28658f2d9089da076961a599833a28 CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-11-12_22:51:20 Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded I got 1 min 53 sec and in Version: 6.1.2.1 Build ID: 65905a128db06ba48db947242809d14d3f9a93fe CPU threads: 4; OS: Windows 6.1; UI render: default; Locale: ru-RU (ru_RU); Calc: group threaded I got 20 sec Dennis Francis committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/4aea832ffebefd62e5f9a3b34dca493b21a16bb0%5E%21 tdf#121388 : Disable threading and dep evaluation for IF... It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. it takes 5 seconds now in Version: 6.3.0.0.alpha0+ Build ID: c7ad7849d54fd3dad67e7779102f65b8b2f04881 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Dennis Francis, thanks for fixing this issue. Should it be backported to 6-2 branch ? (In reply to Xisco Faulí from comment #4) > it takes 5 seconds now in > > Version: 6.3.0.0.alpha0+ > Build ID: c7ad7849d54fd3dad67e7779102f65b8b2f04881 > CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; > Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US > Calc: threaded > > @Dennis Francis, thanks for fixing this issue. Should it be backported to > 6-2 branch ? Yes, I will shortly put a patch for 6-2 but have to do it manually it seems. Thanks. Dennis Francis committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/34088a9b994f96a69a777a1cf61ab50cf789b9e6%5E%21 tdf#121388 : Disable threading and dep evaluation for IF... It will be available in 6.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 6.3.0.0.alpha0+ Build ID: 6d52cd1c0b7270a512a8e4ea988432fdad3e4385 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Dennis Francis, thanks for fixing this!! |