| Summary: | Pressing twice on the "Help" button causes LibreOffice application to crash when the focus is on one of the tabs on Properties window | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Liad Skiva <liskiva8> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | caolan.mcnamara, oliver.brinzing, xiscofauli |
| Priority: | highest | Keywords: | bibisected, bisected, regression |
| Version: | 6.1.0.0.alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://crashreport.libreoffice.org/stats/signature/vcl::Window::get_ungrouped_preferred_size() | ||
| Whiteboard: | target:6.2.0 target:6.1.4 | ||
| Crash report or crash signature: | ["vcl::Window::get_ungrouped_preferred_size()"] | Regression By: | |
|
Description
Liad Skiva
2018-11-15 08:03:17 UTC
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a4c464b49dbfa2801818ead1b50bc9580824d00 author Caolán McNamara <caolanm@redhat.com> 2018-02-19 16:33:35 +0000 committer Caolán McNamara <caolanm@redhat.com> 2018-02-22 22:07:38 +0100 commit 6a4c464b49dbfa2801818ead1b50bc9580824d00 (patch) tree 3d6381b6b13576bc536670992b36784436486e95 parent f7733528e88a6619f82b54b59e92a9bca72c0a89 (diff) weld native message dialogs Bisected with: bibisect-linux64-6.1 Adding Cc: to Caolán McNamara The behaviour with the customize dialog. I guess some other might be affected as well... After the first dialog, the focus is in the tabcontrol and that is used as the parent for the dialog, but the builder thinks it needs to insert a new page to contain the new widgets, although its a new toplevel Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/1d988778095ecbe84f1a1002511377d0708b3443%5E%21 Resolves: tdf#121432 don't insert an extra page when parent is tabcontrol It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. backport to 6-1 in gerrit Verified in Version: 6.2.0.0.alpha1+ Build ID: 5edc23dbc53773536265fd6a54319d9cd1cd9e99 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Caolán, Thanks for fixing this!! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/22f4a98bae32dedb0b1c24e9b86876041532168c%5E%21 Resolves: tdf#121432 don't insert an extra page when parent is tabcontrol It will be available in 6.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |