| Summary: | CRASH: Closing LibreOffice after installing an extension with the extension manager open | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Xisco Faulí <xiscofauli> |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, markus.mohrhard, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 5.4.0.0.alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://crashreport.libreoffice.org/stats/signature/SfxBroadcaster::Broadcast(SfxHint%20const%20&) | ||
| Whiteboard: | target:6.3.0 target:6.2.0.2 target:6.1.5 | ||
| Crash report or crash signature: | ["SfxBroadcaster::Broadcast(SfxHint const &)"] | Regression By: | |
|
Description
Xisco Faulí
2018-12-21 17:05:24 UTC
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=db1726216ba200c8a55c23a9d8c2ffd2066263a7 author Markus Mohrhard <markus.mohrhard@googlemail.com> 2016-12-29 00:52:09 +0100 committer Markus Mohrhard <markus.mohrhard@googlemail.com> 2016-12-29 18:22:05 +0000 commit db1726216ba200c8a55c23a9d8c2ffd2066263a7 (patch) tree d9cb2af69b5a0b160b0c5cbf1513b532d735846b parent 20528001b5f4a652889860583bbc95861d8f8129 (diff) process all outstanding events before shutdown, tdf#104969, tdf#104286, tdf#104399 Bisected with: bibisect-linux-64-5.4 Adding Cc: to Markus Mohrhard @Caolán, I thought you could be interested in this issue... the prompt to restart comes from the close of that dialog, in this case the close is not from the user, but from the app shutdown. Looks to me that if we call clearModified in queryTermination which happens on app shutdown then the dialog won't appear and the problem doesn't arise Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f877d2882e4d257136ef2de901ff4f71b71916bd%5E%21 tdf#122269 don't prompt to restart if we're exiting the application anyway It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. that seems sane to me, backport to 6-2 in gerrit Verified in Version: 6.3.0.0.alpha0+ Build ID: 9520378e37b97b0a44130c86be482060465b479e CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Caolán, Thanks for fixing this!! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/14f827ee132e06fbd4131df2ba4141715db4caab%5E%21 tdf#122269 don't prompt to restart if we're exiting the application anyway It will be available in 6.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/a93713359265a9a1403c744e467eb5faa09cc747%5E%21 tdf#122269 don't prompt to restart if we're exiting the application anyway It will be available in 6.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |