| Summary: | Crash in debug build, when save a pptx file with custom shape to strict ODF 1.2 | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Regina Henschel <rb.henschel> |
| Component: | Impress | Assignee: | Julien Nabet <serval2412> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | serval2412 |
| Priority: | high | Keywords: | haveBacktrace |
| Version: | 6.3.0.0.alpha0+ | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| Whiteboard: | target:6.3.0 target:6.2.0.2 target:6.1.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
File with custom shape, not preset shape
Crash information by Visual Studio 2017 bt with debug symbols |
||
Created attachment 147841 [details]
Crash information by Visual Studio 2017
The file contains the crash message and the "Aufrufliste" as generated by Visual Studio.
The problem seems to be rLocalName="sub-view-size". Then it is likely related to bug 105603. Created attachment 147845 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Let's increase the importance since: - it's a crash - it occurs on several platforms Regina: as you may have seen, I submitted this patch on gerrit for master: https://gerrit.libreoffice.org/#/c/65623/ Julien: Yes, that works. I had just tried with
if (rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
{
...
}
Please change the comment. It is not about draw:display but about attribute sub-view-size.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/1141fc3247bf8cf901af3f9c0194cbb2621ff707%5E%21 tdf#122335: sub-view-size can only be used with ODF ver > 1.2 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Backports here: 6.2: https://gerrit.libreoffice.org/#/c/65626/ 6.1: https://gerrit.libreoffice.org/#/c/65627/ Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f23b7a8a73114d65d1aa38e5a648e622a56f6ee6%5E%21 tdf#122335 follow-up, typo It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/e694119f1246e46b2f525e6111b3c7c775909f91%5E%21 tdf#122335: sub-view-size can only be used with ODF ver > 1.2 It will be available in 6.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/26ad33a6f1e894d7352fb3d175c8d15dd28673b2%5E%21 tdf#122335: sub-view-size can only be used with ODF ver > 1.2 It will be available in 6.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 147840 [details] File with custom shape, not preset shape Take a debug build and set it to save to "ODF 1.2". Open attached file and save it to .odp. Near the end of progress bar it crashes.