| Summary: | Lines created in Draw are not visible when printed (Windows-only) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | helmut |
| Component: | Printing and PDF export | Assignee: | Armin Le Grand <Armin.Le.Grand> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | Armin.Le.Grand, aron.budea, himajin100000, ilmari.lauhakangas, rb.henschel, telesto, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, regression |
| Version: | 6.2.0.0.alpha0+ | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Windows (All) | ||
| Whiteboard: | target:6.3.0 target:6.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 112485, 121235 | ||
| Attachments: | Example file | ||
|
Description
helmut
2018-12-30 21:34:20 UTC
First off, thanks for testing LibreOffice 6.2.0.1 and 6.3.0.0! Appreciated! Repro Version: 6.3.0.0.alpha0+ Build ID: beae6c7a7f163daad0d4dea63a3d403af2745fd1 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-06_23:55:16 Locale: en-US (nl_NL); UI-Language: en-US Calc: CL no repro with Version: 6.0.0.0.alpha1+ Build ID: 6eeac3539ea4cac32d126c5e24141f262eb5a4d9 CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: nl-NL (nl_NL); Calc: CL Created attachment 147905 [details]
Example file
Hi telesto, is it reproducible if printed to File? (In reply to Xisco Faulí from comment #3) > Hi telesto, > is it reproducible if printed to File? I used a PDF printer.. No issue with PDF export Repro with MS print to pdf. Bibisected with win32-6.2 repo to https://gerrit.libreoffice.org/plugins/gitiles/core/+/b9fa01a8d1137a95af9865a3e47995734c40da6e%5E!/ Support buffering SystemDependent GraphicData Adding Cc: to Armin Le Grand May have to do with WinSalGraphicsImpl::drawPolyPolygon and the comment I already added (see 'One more hint: This *may* also be needed now in ::drawPolyLine below')... Problem here will be to get a reliably testable failure - checking... @buovjaga: I *may* need help with ckecking when I have a possible solution on gerrit (just to warn...) Possible fix on gerrit (see https://gerrit.libreoffice.org/#/c/66190/) About reliable testing: using MS PDF printer indeed works as test case here - thanks for mentioning it here! Comitted, done. Please have a look... Armin Le Grand committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/6e3c4ae8bca898700cde9caaff43c3a8a61eebc2%5E%21 tdf#122384 Added isPrinter support to WinSalGraphicsImpl::drawPolyLine It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 121567 has been marked as a duplicate of this bug. *** Hi *, Could you please try to verify the fix with a master build from http://dev-builds.libreoffice.org/daily/master/ ? (In reply to Xisco Faulí from comment #12) > Hi *, > Could you please try to verify the fix with a master build from > http://dev-builds.libreoffice.org/daily/master/ ? @42 is not working now. Can we use Win-x86@39 ? > @42 is not working now. Can we use Win-x86@39 ?
Hmmm, latest build for Win-x86@39 is 2019-01-09_00.08.42
It is fixed in my local build Version: 6.3.0.0.alpha0+ (x64) Build ID: 6e3c4ae8bca898700cde9caaff43c3a8a61eebc2 CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded In my local build bug 121567 is fixed by the patch from Armin too. Hi Regina, Thanks for checking. Let's then backport the fix to 6-2 and 6-2-0 and set this one as VERIFIED Armin Le Grand committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/5af161ebbe2a0183c1302099c995548d82965fa9%5E%21 tdf#122384 Added isPrinter support to WinSalGraphicsImpl::drawPolyLine It will be available in 6.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Armin Le Grand committed a patch related to this issue. It has been pushed to "libreoffice-6-2-0": https://git.libreoffice.org/core/+/d37d6070dd5300d249940d7f8d960ff6d4d9a036%5E%21 tdf#122384 Added isPrinter support to WinSalGraphicsImpl::drawPolyLine It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |