| Summary: | Cannot use double-click to apply text highlight | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Mike Kaganski <mikekaganski> |
| Component: | Writer | Assignee: | Mike Kaganski <mikekaganski> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | dgp-mail, glogow, telesto, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 5.0.0.5 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.3.0 target:6.1.5 target:6.2.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 113731, 119334 | ||
|
Description
Mike Kaganski
2019-01-03 11:05:11 UTC
Can't that be that previously, single-click event only generated after timer timeout (if not cancelled by a double-click event coming first), and the commit changed it to happen when idle, which might happen before second click? I'd suppose that using timer for single-click would be correct? I confirm the observation with Version: 4.4.7.2 Build-ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Gebietsschema: de_DE (it works) and Version: 6.3.0.0.alpha0+ (x64) Build ID: ffa5b8a82eab18041bbee4d6914892b82c7801d3 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-12-19_03:24:54 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded (doesn't work) A code pointer: see m_aTemplateIdle initialization at SwEditWin::SwEditWin (sw/source/uibase/docvw/edtwin.cxx). The comment there states:
> // TemplatePointer for colors should be resetted without
> // selection after single click
and the event there is indeed an Idle, not a timer set to a double-click timeout. Possibly it's enough to change it to such, but is there a more reliable way to do it - do we generate "single click" event somewhere when double-click timeout elapsed without a click?
Indeed, the change is in the bibisected range, and is https://git.libreoffice.org/core/+/821ae0fb9fa63e0171f987d5ec210ec121978b8f. s/in/related to/ Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/6207c51880c9165eedb1d1af7fdc5e179bc8844d%5E%21 tdf#122442: use Timer to detect single-clicks vs double-clicks It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/3d6ca7b271de18ba27a4d71ca7feef452e38c47c%5E%21 tdf#122442: use Timer to detect single-clicks vs double-clicks It will be available in 6.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Issue verified in Version: 6.3.0.0.alpha0+ Build ID: 892a5cfe557edb405ec0037676f02a1c24dd76ec CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Mike Kaganski, Thanks for fixing this!! Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/8b8d1af48d40494e0b0c5d2c8d2b12fb9e62b23a%5E%21 tdf#122442: use Timer to detect single-clicks vs double-clicks It will be available in 6.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |