Bug 122565

Summary:	Classification dialog - Button "bold" works only in dialog
Product:	LibreOffice	Reporter:	raal <raal>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	VERIFIED FIXED
Severity:	normal	CC:	aron.budea, cno, dgp-mail, luke, raal, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	6.1.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=107035 https://bugs.documentfoundation.org/show_bug.cgi?id=122491
Whiteboard:	target:7.0.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	123810

Description raal 2019-01-08 15:05:03 UTC

Description:
Button bold works only in dialog

Steps to Reproduce:
 - open new file
 - enable TSCP classification toolbar
 - click butto Manage document classification
 - set classification
 - click "B" button (Bold)
 - click OK

Actual Results:
text is not bold

Expected Results:
text is bold


Reproducible: Always


User Profile Reset: No



Additional Info:

Comment 1 raal 2019-01-08 15:06:13 UTC

This seems to have begun at the below commit.
Adding Cc: to Luke Deller ; Could you possibly take a look at this one? Thanks
 65fe934c926a67f6b85cc489028aa49640bd326c is the first bad commit
commit 65fe934c926a67f6b85cc489028aa49640bd326c
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Mon Mar 5 11:21:37 2018 -0800

    source 18cbb8fe699131a234355e1d00fa917fede6ac46
author Luke Deller <luke@deller.id.au>2018-03-05 00:14:28 +1100 committerMiklos Vajna <vmiklos@collabora.co.uk>2018-03-05 10:26:47 +0100 commit18cbb8fe699131a234355e1d00fa917fede6ac46 (patch) tree0642ae0059b821ed52228bde8bb526c15e2ec285 parent60ac7418747530a006894a7941c67c5006d6158c (diff)
tdf#107035 Fix field character style DOCX import

Comment 2 Dieter 2019-01-08 15:49:44 UTC

I confirm it with

Version: 6.3.0.0.alpha0+ (x64)
Build ID: ffa5b8a82eab18041bbee4d6914892b82c7801d3
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-12-19_03:24:54
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

Comment 3 Aron Budea 2020-04-13 05:55:30 UTC

Seems good to me in 7.0.0.0.alpha0+ (95dbfd517240666e5b9a9fd7ac1d47d799235a62) / Ubuntu.

Fixing commit identified as the following, closing as FIXED:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=635bd7fbcb1d131627ba98fd9085dd2b11e0d33c
author		Michael Stahl <Michael.Stahl@cib.de>	2019-11-19 17:33:05 +0100
committer	Michael Stahl <michael.stahl@cib.de>	2019-11-20 11:59:40 +0100

sw: revert change in expanding hints in SwXText::insertTextContent()

Comment 4 Xisco Faulí 2020-04-14 13:29:31 UTC

Verified in

Version: 7.0.0.0.alpha0+
Build ID: 35fc5ef0a759884b24ed8b83cd05702a0fab64cc
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

I've created a uitest for it < https://gerrit.libreoffice.org/c/core/+/92191 > however the click on bold button doesn't work properly...