| Summary: | Dialog theming/UX - edit menu / text handles | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Nicolas Christener <contact> |
| Component: | iOS Editor | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | aron.budea, tml |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | iOS | ||
| Whiteboard: | target:6.3.0 target:6.4.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
screenshot of the current menu above a selection
screenshot of work in progress newer screenshot |
||
|
Description
Nicolas Christener
2019-01-08 19:47:42 UTC
Let's confirm. Created attachment 151809 [details]
screenshot of the current menu above a selection
Changing the look of the handles should be easily doable, I think.
The menu above is harder. We already have a menu with graphical buttons for Cut, Copy, and Paste (see screenshot), but currently it doesn't appear immediately when something has been selected, but you have to tap lightly once more on the selection. (Not sure if that is intentional or a bug.) Also, the menu seems to overlap the selected text. Changing the menu to look like Apple's, with text instead, is doable, but not trivial, I think. Adding more entries to this menu is far from trivial either.
Some code pointers in case I forget: The menu above the selection is actually called a "context toolbar" in loleaflet, and is created in loleaflet/src/control/Control.ContextToolbar.js in _initLayout(). IMHO the menu (context toolbar) should show right after the selection was made. This is how iOS does it and I also think user would expect it. Making it black (like the ones in native apps) and then add cut, copy, paste would already be a nice improvement. Created attachment 151810 [details]
screenshot of work in progress
Actually, producing something that looks quite close to the native iOS horizontal context menu was not that hard after all using CSS. It is already almost working, just the text position in the cells and the position of the whole table need to be corrected a bit.
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/532e70db8d719e5f330ab19bc40a78fe00fd7a05%5E%21 tdf#122572: Use a context toolbar in the iOS app that looks more native Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/4249722b12da8470634d1685afef36b97b557e7f%5E%21 tdf#122572: Use the _UNO() function instead of duplicating what it does Created attachment 151864 [details]
newer screenshot
Tweaked it a bit more. I see that there is a thin rectangular border around it still that shows up outside the routed corner, some further small change to the CSS is needed.
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/fd3fa85426736db8933adbc7e050236dbf1e4782%5E%21 tdf#122572: Don't underline the entries in the iOS selection context menu Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/291d9dd1011d13cf63292f35245c408babf20c66%5E%21 tdf#122572: Avoid thin rectangular border around context toolbar on iOS More functionality will become available in the "context menu", which is a technically quite different thing than the "context bar" that has just Cut, Copy and Paste. That work is however in another branch at the moment, but will be ported to the branch from which the iOS app is built. We will try to make the context menu use the same native lookalike styling as the context bar. Note that I mistakenly used the term "context menu" for the context bar in previous comments and commits. Easy to get confused... Seems that even after 5448916f98c1480cfbc64f58e6d4f1cdb3fd133f ("Temporarily resurrect the context toolbar, but for the iOS app only") the context toolbar did not always show up when tapping on a selection. This seems to be fixed by https://gerrit.libreoffice.org/#/c/77574/ . Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/c7b1159f36dea4ee3524a0ed71885388b721d520%5E%21 tdf#122572: Temporarily resurrect the context toolbar, for the iOS app only Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/5d4f845aec0cbe2f4037a3d25cd592007d1604d3%5E%21 tdf#122572: Make the context toolbar show up more reliably Should be fixed now, also in the branch from which the iOS app is built, resolving. |