Bug 122919

Summary: EDITING The LibreOffice crashes when we insert a picture from the gallery
Product: LibreOffice Reporter: NISZ LibreOffice Team <libreoffice>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: VERIFIED FIXED    
Severity: major CC: dgp-mail, kelemeng, nemeth, noelgrandin, xiscofauli
Priority: high Keywords: bibisected, bisected, regression
Version: 6.3.0.0.alpha0+   
Hardware: All   
OS: All   
Whiteboard: target:6.3.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 99671    
Attachments: Screenshot of the error message.
Bibisect log file.

Description NISZ LibreOffice Team 2019-01-24 08:55:34 UTC
Description:
The LibreOffice crashes when we insert a picture from the gallery.

Steps to Reproduce:
    1. Create a new document in LibreOffice Writer.
    2. On the Insert tab, choose Media and click Gallery. The Gallery Side bar appears.
    3. Insert a picture by right clicking it and choose the Insert menu item.

Actual Results:
The LibreOffice crashes.

Expected Results:
The picture should appears.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 NISZ LibreOffice Team 2019-01-24 08:56:29 UTC
Created attachment 148585 [details]
Screenshot of the error message.
Comment 2 NISZ LibreOffice Team 2019-01-24 08:57:04 UTC
Created attachment 148586 [details]
Bibisect log file.
Comment 3 Dieter 2019-01-24 09:05:18 UTC
I confirm it with

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded


But not with
Version: 6.1.4.2 (x64)
Build-ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group threaded
Comment 4 Xisco Faulí 2019-01-24 15:31:36 UTC
Regression introduced by:

author	Noel Grandin <noel.grandin@collabora.co.uk>	2018-12-19 16:30:34 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2018-12-20 10:56:01 +0100
commit 1b7bcaa714f0af45c6a9660d1f0940cb7931ba0f (patch)
tree 8623a38ea87f23b549599ba4a1195bb8eaf17a36
parent 146f98e7100ae57ced080c7d9fa028f01df99ca8 (diff)
use unique_ptr in svx

Bisected with: bibisect-linux64-6.3

Adding Cc: to Noel Grandin
Comment 5 Noel Grandin 2019-02-07 14:49:52 UTC
fixed with commit fc723fd872d5ffa52551f570b64c2b924d1cc97e
Comment 6 Xisco Faulí 2019-02-11 10:49:19 UTC
Hi Noel,
This issue is half fixed.
Right click - Insert is fixed in

Version: 6.3.0.0.alpha0+
Build ID: 8c0bb7692a5ae3f1c0d1966903baef013b50a7e6
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

however it still crashes with right click - Insert As Background...
Comment 7 Xisco Faulí 2019-02-11 13:11:03 UTC
(In reply to Xisco Faulí from comment #6)
> 
> however it still crashes with right click - Insert As Background...

Fixed now with https://cgit.freedesktop.org/libreoffice/core/commit/?id=379ab849b415d61c542fc5ebd613e94052df4afb. i didn't change the ID either :-D
Comment 8 Dieter 2019-07-19 14:39:46 UTC
Verified with

Version: 6.4.0.0.alpha0+ (x64)
Build ID: 2f2f4767089512c34514896bc37823f9310e9dd4
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-07-10_02:13:57
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded