| Summary: | Number gets reversed when entered in Format Paragraph / Tabs / Position field | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | dorothee.buisson |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | aron.budea, caolan.mcnamara, jonathan.kreider, petervrijlandt, philippe.delbouys, serval2412, TorrAB, wahl.g, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.2.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.3.0 target:6.2.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107642 | ||
|
Description
dorothee.buisson
2019-02-13 07:07:56 UTC
On Win with master sources updated yesterday, I could reproduce this. I don't reproduce this with LO 6.1.5 => regression Caolán: do you think it may be related with welding migration done mid september 2018 (see https://cgit.freedesktop.org/libreoffice/core/commit/?id=03cecc2985c10ecfb2efab28f5b03e451e82c777) ? Hello All, Even i am so new to LO Development, i have checked the problem with my local build: libreoffice-6.1.5.1,and could not reproduce it. I debugged "/core/vcl/source/control/field.cxx" and it seems to me that the problem may be related to: https://gerrit.libreoffice.org/plugins/gitiles/core/+/70519a43e0d89a6b5d89859a6851f8c757c6b0c7 I will build with related change if i have enough time. As ı have said i am so new to the development environment, i hope the info helps. Best Regards It's gonna take some time to build without this part since include/rtl/ustrbuf.hxx has been modified (perhaps a full rebuild?) https://cgit.freedesktop.org/libreoffice/core/commit/?id=70519a43e0d89a6b5d89859a6851f8c757c6b0c7 (In reply to Julien Nabet from comment #4) > It's gonna take some time to build without this part since > include/rtl/ustrbuf.hxx has been modified (perhaps a full rebuild?) > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=70519a43e0d89a6b5d89859a6851f8c757c6b0c7 It doesn't worth building and as i see it is most probably caused by the commit you mentioned at comment 2: https://cgit.freedesktop.org/libreoffice/core/commit/?id=03cecc2985c10ecfb2efab28f5b03e451e82c777) (In reply to Julien Nabet from comment #2) > I don't reproduce this with LO 6.1.5 => regression > > Caolán: do you think it may be related with welding migration done mid > september 2018 (see > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=03cecc2985c10ecfb2efab28f5b03e451e82c777) ? Yes, it's related. Bisected with bibisect-linux64-6.2 Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/038634b63e997db80c09af3c6493364fa4431bcf%5E%21 Resolves: tdf#123426 don't reformat tabstop pos while editing It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. fixed in master, backport in 6-2 On Win7 with master sources updated today, I confirm it works. Thank you Caolán! *** Bug 123758 has been marked as a duplicate of this bug. *** (In reply to Cihan Mete Bahadir from comment #5) > It doesn't worth building and as i see it is most probably caused by the > commit you mentioned at comment 2: > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=03cecc2985c10ecfb2efab28f5b03e451e82c777) Actually it was caused by two commits, that one from comment 2, which caused input to be messed up, and then the following resulted in the input getting reversed: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ce5d39689fda418e8f2d7d9c1124190b2cbad7a author Caolán McNamara <caolanm@redhat.com> 2018-11-14 13:52:06 +0000 committer Caolán McNamara <caolanm@redhat.com> 2018-11-15 18:17:35 +0100 bind SalInstanceSpinButton to FormattedField *** Bug 123820 has been marked as a duplicate of this bug. *** Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/a5a6e9c8021d547943ad8085873b82ec68136c18%5E%21 Resolves: tdf#123426 don't reformat tabstop pos while editing It will be available in 6.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 123945 has been marked as a duplicate of this bug. *** *** Bug 124078 has been marked as a duplicate of this bug. *** *** Bug 124126 has been marked as a duplicate of this bug. *** |