Bug 123460

Summary: EDITING DOCX Paragraph move with track changes leaves empty paragraph
Product: LibreOffice Reporter: NISZ LibreOffice Team <libreoffice>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: ilmari.lauhakangas, kelemeng, nemeth
Priority: medium Keywords: filter:docx, implementationError
Version: 6.2.0.3 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=104797
https://bugs.documentfoundation.org/show_bug.cgi?id=149711
Whiteboard: target:6.3.0 target:6.2.5
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 115709    
Attachments: Accept all tracked changes. (in Word and Writer)
Example file from Word.

Description NISZ LibreOffice Team 2019-02-14 09:38:54 UTC
Description:
The paragraph move with track changes in DOCX documents created with Microsoft Word 2016 is incorrect when we open the document in LibreOffice Writer and accept  all changes.

Steps to Reproduce:
    1. Create a new document in Microsoft Word 2016.
    2. Type two paragraphs of text and press Enter.
    3. Enable track changes with Review->Track Changes.
    4. Select the first paragraph and press Ctrl + X.
    5. Select the empty paragraph and press Ctrl + V.
    6. Save the file as DOCX.
    7. Open the same file in LibreOffice Writer.
    8. Click Edit->Track Changes->Accept All.

Actual Results:
The first paragraph is empty.

Expected Results:
The original second paragraph should be the first paragraph. (This happens in Word when we accept the change.)


Reproducible: Always


User Profile Reset: No



Additional Info:
LibreOffice details:
Version: 6.3.0.0.alpha0+
Build ID: 950bdd703bb4430526598a132897a6b77cb21005
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: threaded
Comment 1 NISZ LibreOffice Team 2019-02-14 09:40:34 UTC
Created attachment 149290 [details]
Accept all tracked changes. (in Word and Writer)
Comment 2 NISZ LibreOffice Team 2019-02-14 09:40:59 UTC
Created attachment 149291 [details]
Example file from Word.
Comment 3 Durgapriyanka 2019-02-18 15:27:19 UTC
Thank you for reporting the bug. I can confirm the bug is present in 

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 4 Buovjaga 2019-03-05 18:15:54 UTC
In versions prior to 6.2, the changes are not even recognised.
Comment 5 László Németh 2019-04-26 15:42:48 UTC
Proposed fix: https://gerrit.libreoffice.org/#/c/71382/

Note: Interestingly, online version of MSO leaves empty paragraphs, too.
Comment 6 Commit Notification 2019-04-29 10:15:30 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be%5E%21

tdf#123460 DOCX track changes: moveFrom completely

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2019-05-24 07:12:35 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/4f279b95efbc113d3c1907a232a4e647e2b4054f%5E%21

tdf#123460 DOCX track changes: moveFrom completely

It will be available in 6.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.