| Summary: | Paragraph Option: Orphan Control or Widow control should be tri-state | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Adalbert Hanßen <adalbert.hanssen> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.2.0.0.alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.3.0 target:6.2.4 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
state of the dialogue in Version: 6.3.0.0.alpha0+: minus signs on orphans and widows
state of the dialogue in Version 6.3.0.0.0 alpha+ after clicking on 'Do not split paragraph'. version 6.1.4.2 with German locale: half checked state version 6.1.4.2. with German locale: 'Do not split paragraph' version 1.6.4.2. with German locales: 'Do not split paragraph' greyed out, orphan and widow control active A file containing the bug and screenshots of every single step to reporoduce it. |
||
|
Description
Adalbert Hanßen
2019-02-18 19:36:19 UTC
Created attachment 149400 [details]
state of the dialogue in Version: 6.3.0.0.alpha0+: minus signs on orphans and widows
In this case it is possible to check 'Do not split paragraph' simultaneously unchecking the lower two options.
Created attachment 149401 [details]
state of the dialogue in Version 6.3.0.0.0 alpha+ after clicking on 'Do not split paragraph'.
Observe that the number of lines for orphan/widow control is zero (I don't know how I got there, possibly a setting from working on the file with an earlier version of LO Writer).
Created attachment 149402 [details]
version 6.1.4.2 with German locale: half checked state
observe: There are no check-marks on orphan and widow control.
Created attachment 149403 [details]
version 6.1.4.2. with German locale: 'Do not split paragraph'
In this case the lower check boxes for orphan and widow control are greyed out. The previous state of the respective control values are still visible.
Created attachment 149404 [details]
version 1.6.4.2. with German locales: 'Do not split paragraph' greyed out, orphan and widow control active
Hello Adalbert Hanßen, Could you please attach a document to reproduce the issue? I've been trying to reproduce it from scratch but the behaviour is correct. Version: 6.3.0.0.alpha0+ Build ID: f8ca6e0a59bff51fcb09af4fa6d9cd458b32f223 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. Created attachment 150205 [details]
A file containing the bug and screenshots of every single step to reporoduce it.
Steps to reproduce: 1. Open attached document 2. Select paragraphs 1 and 2 ( numbering list ) 3. Format - paragraph 4. Text flow tab 5. Click on Orphan Control or Widow control -> Checkboxes are not tri-state anymore Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=eb1d6b16e787a87c3d918135ca98c5694d352557 author Caolán McNamara <caolanm@redhat.com> 2018-06-13 21:26:35 +0100 committer Caolán McNamara <caolanm@redhat.com> 2018-06-14 13:22:28 +0200 commit eb1d6b16e787a87c3d918135ca98c5694d352557 (patch) tree bfcf9fe1a699e8b934b8ccde234ddaa72669b409 parent 1f91ebb586356aa77ecced15cd5e049f1ebca70c (diff) weld SvxExtParagraphTabPage @Caolán, later on, the checkboxes became unclickable in https://cgit.freedesktop.org/libreoffice/core/commit/?id=6d184e2e23b319128f94649f4e15c2f7bcbffca9 author Caolán McNamara <caolanm@redhat.com> 2018-09-15 15:42:18 +0100 committer Caolán McNamara <caolanm@redhat.com> 2018-09-18 18:12:10 +0200 commit 6d184e2e23b319128f94649f4e15c2f7bcbffca9 (patch) tree 23541a6cccacb3a315196ed89c39a7e4a577cc9b parent 03cecc2985c10ecfb2efab28f5b03e451e82c777 (diff) weld SwParaDlg Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0b3419f1ab28941d7ab8a38b2ceedbb5e6dfaa00%5E%21 Resolves: tdf#123550 allow returning to TRISTATE_INDET It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fixed in master, backports to 6-2 in gerrit Verified in Version: 6.3.0.0.alpha0+ Build ID: 705558aa455403cd006993f95b5b13981fdb3483 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Caolán, thanks for fixing this issue!! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/99ec13e699ff2788db7c8eda7d9c41c1faa3d94d%5E%21 Resolves: tdf#123550 allow returning to TRISTATE_INDET It will be available in 6.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |