Bug 123722

Summary: Data labels number format
Product: LibreOffice Reporter: raal <raal>
Component: ChartAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: catbill76, kyoshida, oliver.brinzing, raal, varga.balazs3, xiscofauli
Priority: medium Keywords: bibisected, bisected, regression
Version: 4.4.0.3 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=95425
https://bugs.documentfoundation.org/show_bug.cgi?id=123774
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 108542    
Attachments: file for test
chart number format selection

Description raal 2019-02-26 15:31:28 UTC 
Description:
Data labels number format not preserved

Steps to Reproduce:
1.open attached file
2.double click on chart
3.right click on data point -> select "Insert data labels" from menu
4. right click on data point -> select "Format data labels" from menu
5. click Number formats button
6. set own format, for example ###,000 in Format code textbox
7. OK; and close dialog with OK
8. reopen dialog; click Number formats button

Actual Results:
format set to General

Expected Results:
format is ###,000


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 raal 2019-02-26 15:31:54 UTC 
Created attachment 149601 [details]
file for test
Comment 2 raal 2019-02-26 15:33:19 UTC 
This seems to have begun at the below commit.
Adding Cc: to Kohei Yoshida ; Could you possibly take a look at this one?
Thanks
 9135b8b04a9f2ff33d1500876e48c6d2d42ecae0 is the first bad commit
commit 9135b8b04a9f2ff33d1500876e48c6d2d42ecae0
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sat Mar 14 21:46:04 2015 +0800

    source-hash-1d38cb365543924f9c50014e6b2227e77de1d0c9
    
    commit 1d38cb365543924f9c50014e6b2227e77de1d0c9
    Author:     Kohei Yoshida <kohei.yoshida@collabora.com>
    AuthorDate: Fri Jun 13 11:12:50 2014 -0400
    Commit:     Kohei Yoshida <kohei.yoshida@collabora.com>
    CommitDate: Thu Jun 19 14:46:56 2014 -0400
    
        fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Comment 3 Oliver Brinzing 2019-02-26 17:59:36 UTC 
Created attachment 149607 [details]
chart number format selection

selection in number format dialog is not correct