| Summary: | Option's AutoCaption preference should show Above as default position of table captions (again) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Thomas Lendo <thomas.lendo> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, dgp-mail, heiko.tietze, serval2412, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.3.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=40457 https://bugs.documentfoundation.org/show_bug.cgi?id=115032 |
||
| Whiteboard: | target:6.2.5 target:6.3.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 113944, 114426 | ||
| Attachments: | How it looks in LibreOffice 6.3 master | ||
|
Description
Thomas Lendo
2019-05-06 04:59:00 UTC
Adding Julien Nabet and Heiko Tietze as they were also involved in bug 115032. I confirm it with Version: 6.3.0.0.alpha1+ (x64) Build ID: e92dcfdc7bd7b237e0bee26ff226a102d9e8e766 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-05-14_00:00:57 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded On a fresh build it does place the caption above. So cannot confirm. Version: 6.3.0.0.alpha1+ Build ID: b004b7f3c1a28ebab1823bdbe38660b6c44483b1 CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded Caption is inserted above in Version: 6.3.0.0.alpha1+ Build ID: e3015d7021e689c71c2ed8e5dd01a74d832c84f0 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Steps: 1. Insert table 2. Context menu - Insert Caption Please, provide the steps to reproduce the problem... Xisco, I confirm your steps, but the bug is about the options dialog Steps to reproduce: 1. Open Options => AutoCaption 2. Default setting for table caption is below (should be above) Created attachment 151621 [details] How it looks in LibreOffice 6.3 master oh, sorry, you're right. How it looks in master with a clean profile Version: 6.3.0.0.alpha1+ Build ID: e3015d7021e689c71c2ed8e5dd01a74d832c84f0 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Indeed, this is a recent regression, bisecting... Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3bd103064ba719013471d9664ea2c1f207b84d90 author Caolán McNamara <caolanm@redhat.com> 2018-12-11 20:30:52 +0000 committer Caolán McNamara <caolanm@redhat.com> 2018-12-12 21:07:12 +0100 commit 3bd103064ba719013471d9664ea2c1f207b84d90 (patch) tree b15086268b4858614f19b746e67b870945de1b0b parent 27995e638e1582b443befa93bc5dfd5970a38ef2 (diff) weld SwCaptionOptPage Bisected with: bibisect-linux64-6.3 Adding Cc: to Caolán McNamara The previous code doesn't look right either though. In 6.1
if (m_pPosBox->IsEnabled())
m_pPosBox->SelectEntryPos(pOpt->GetPos());
else
m_pPosBox->SelectEntryPos(0);
select position 0 if its disabled, leave it as the default if it is enabled.
Things start off disabled, so its 0 starting off and the option pos is ignored, but on changing entries the settings are saved, so if you cursor away from the first entry, then the entry 0 get saved as the default for the next visit.
So on initial visit
tables is disabled and shows "above", enable it and it shows "below". Cancel to not save changes and revisit
tables is disabled, click on frame, click on table again, it shows "above", enable it and it sticks as "above". Because the change away from frame and back to table has saved the "above" position in
https://gerrit.libreoffice.org/#/c/72846/ to change the default for Tables to above in the settings reserved for these defaults Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/6d7a32ffd1bd1530ac9bf38d10c89fe7cd598f87%5E%21 Resolves: tdf#125128 set Tables as "above" by default It will be available in 6.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/ca86d9c5e10ad7ce88d121dc8d9145058aaad782%5E%21 Resolves: tdf#125128 set Tables as "above" by default It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 6.3.0.0.alpha1+ Build ID: 53325b40b557cc84d8d21c1baa0ef8d3bfc00ab8 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Caolán, thanks for fixing this issue! |