| Summary: | Dialog theming/UX - scaling of tunneled dialog may lead to missing application menu | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Nicolas Christener <contact> |
| Component: | iOS Editor | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | tml |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | iOS | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Video demonstrating the issue | ||
|
Description
Nicolas Christener
2019-05-20 09:04:42 UTC
Created attachment 151526 [details]
Video demonstrating the issue
Moving to NEW as agreed in the ESC meeting This seems to be related to using an external keyboard. I can reproduce it only when I turn on my external keyboard. Weird... The menu and toolbar re-appear if you double-click in the document. I mean double-tap. Actually just tapping once in the document makes the menu and toolbar re-appear. Sigh, and now I can't reproduce it any longer, without doing anything. During the display of the dialog the menu and toolbar are hidden (not sure whether that is intentional), but after closing the dialog, they appear again right away. I suspect it might be the call
> $('#' + strId).parent().css({display: 'none'});
in loleaflet/src/control/Control.LokDialog.js that causes the menubar and toolbar to be hidden, because I think that when I had commented out that, they did not seem to disappear whatever I did. But playing with this code is not 100% repeatable all the time, so it might be just luck, and it is just a guess. Anyway, I don't understand the code at all, so it would be much better if somebody who actually understands it could give some input...
(nah, probably the line mentioned in my previous comment has nothing to do with it) Reliable reproduction steps: Open the Format > Paragraph... dialog. Resize the dialog to be a lot smaller. Double-click somewhere in the dialog outside the controls in it. => You will notice that the document behind the dialog zooms in a lot, and the menubar and toolbar disappear. Click the "Cancel" button in the dialog. => The dialog goes away, and there is stil not menubar or toolbar. At least with an external (Bluetooth) keyboard, this works every time. Clicking in the document at this stage brings back the menubar and toolbar. But they are zoomed and not all of them is visible. (But it works to pinch-zoom the toolbar and menubar smaller...) I tried to trigger this in 4.1.51 (51) - it seems, that the issue is fixed. @tor can you still reproduce it? I can't reproduce, no. So let's mark this as resolved |