| Summary: | Changing percent gradient or color changes chart wall gradient color to black and white | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Cathy Crumbley <catbill76> |
| Component: | Chart | Assignee: | Gabor Kelemen (allotropia) <kelemeng> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | catbill76, Katarina.Behrens, kuba, libreoffice, peekaa, petr.valach, prapasal, serval2412, xiscofauli, yuniko.nwnr |
| Priority: | medium | Keywords: | bibisected, bisected, needUITest, regression |
| Version: | 5.4.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=105922 https://bugs.documentfoundation.org/show_bug.cgi?id=137729 https://bugs.documentfoundation.org/show_bug.cgi?id=132776 |
||
| Whiteboard: | target:6.5.0 target:6.4.0.1 target:6.3.4 target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | data for testing chart wall gradient | ||
|
Description
Cathy Crumbley
2019-05-23 01:42:53 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this. I could reproduce this to on Debian testing with LO 6.1.5.2 Hi Cathy, Julien, I reproduce too with LO 5.4.0.0.alpha1 Build ID: 0b9f9bef65bb21ebb6a64aafad448f7f62dc824a Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; Locale : fr-FR (fr_FR); Calc: CL and upper versions but not with LO 5.3.7.1 Build ID: 376eaac300a303c4ad2193fb7f6a7522caf550b9 Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; Moteur de mise en page : nouveau; Locale : fr-FR (fr_FR); Calc: CL Jacques Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ff1f83dd08b7b0169301ffe0a53499a27af613b9 author Katarina Behrens <Katarina.Behrens@cib.de> 2017-03-31 10:00:40 +0200 committer Katarina Behrens <Katarina.Behrens@cib.de> 2017-03-31 10:54:34 +0000 commit ff1f83dd08b7b0169301ffe0a53499a27af613b9 (patch) tree fa553938d3a2c30af42361156b9ce02967a06ec0 parent 541b377a94fb1247dbf4c39b5bcf55deb8e5ef60 (diff) tdf#105922: Apply custom gradient/hatch even if not saved as preset Bisected with: bibisect-linux-64-5.4 Adding Cc: to Katarina Behrens Actually this is not a regression, before ff1f83dd08b7b0169301ffe0a53499a27af613b9, the values selected in the area dialog weren't saved... If I remove the line 'aString = "gradient";' then it works, however, if we create a gradient in impress and save it, it will be gone after RT OTOH, if the mentioned line is deleted the gradient is saved after RT in the chart. This is all a mystery to me... (In reply to Xisco Faulí from comment #6) > If I remove the line 'aString = "gradient";' then it works, however, if we > create a gradient in impress and save it, it will be gone after RT thus, putting back regression keyword Comparing gradient and hatch files (cui/source/tabpages/tpgradnt.cxx and cui/source/tabpages/tphatch.cxx), I noticed that hatch part contained these lines: m_xMtrDistance->save_value(); m_xMtrAngle->save_value(); m_xLbLineType->save_value(); m_xLbLineColor->SaveValue(); m_xLbBackgroundColor->SaveValue(); in IMPL_LINK_NOARG(SvxHatchTabPage, ClickModifyHdl_Impl, weld::Button&, void) There's no equivalent in gradient part. Now perhaps it's normal. Dear Katarina Behrens (CIB), This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this. *** Bug 127861 has been marked as a duplicate of this bug. *** *** Bug 128617 has been marked as a duplicate of this bug. *** *** Bug 114273 has been marked as a duplicate of this bug. *** Proposed patch: https://gerrit.libreoffice.org/82393 Katarina Behrens committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/34a3afecaaab3dc4898b33e0981d8b231351fe37 tdf#125449 follow-up: unique gradient names in Impress area dlg It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/53c474633c4e658f096669fb0225d751a5701aaf tdf#125449 Fix custom gradient fill settings being lost It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Gabor Kelemen committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/5979fc4a3fa5713b8df49ba624445ce9ed4ccace tdf#125449 Fix custom gradient fill settings being lost It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Katarina Behrens committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/c00775925325b04b3d707df0d494464f864f6fc0 tdf#125449 follow-up: unique gradient names in Impress area dlg It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 6.5.0.0.alpha0+ Build ID: 5059984c44379d09eabf740c21db062b925394ad CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Gabor, @Bubli, thanks for fixing this issue!! Gabor Kelemen committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/d7cf742cde9b174cf83c416fc1618da80a3a13f0 tdf#125449 Fix custom gradient fill settings being lost It will be available in 6.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Katarina Behrens committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/308249b43f8d62967f7bfa974f3e4f3f6182a010 tdf#125449 follow-up: unique gradient names in Impress area dlg It will be available in 6.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 124402 has been marked as a duplicate of this bug. *** *** Bug 128967 has been marked as a duplicate of this bug. *** *** Bug 128597 has been marked as a duplicate of this bug. *** Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/98ba0bdf69ee350a8ec73c80120adc07d76543bf tdf#125449: sd: Add UItest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |