Bug 125755

Summary:	Can't open file containing a "?" (question mark) in the filename
Product:	LibreOffice	Reporter:	Nicolas Christener <contact>
Component:	iOS Editor	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tml
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	iOS
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=128525
Whiteboard:	target:6.5.0
Crash report or crash signature:		Regression By:

Description Nicolas Christener 2019-06-06 17:38:10 UTC

Description:
If a file has a "?" (question mark) in the name, the iOS app can't open it. The loading indicator will stay at 0%.

Example "foo?.odp"

Steps to Reproduce:
1. Create a file with a "?" (question mark) in the name
2. Open the file with the iOS app

Actual Results:
The file can't be loaded.

Expected Results:
The file should be opened or a message indicating that the "?" (question mark) is an issue and the file should be renamed should be shown.


Reproducible: Always


User Profile Reset: No



Additional Info:

Comment 1 Xisco Faulí 2019-06-25 11:46:47 UTC

Moving to NEW as agreed in the ESC meeting

Comment 2 How can I remove my account? 2019-11-21 11:58:37 UTC

Looking at this now.

Comment 3 How can I remove my account? 2019-11-21 12:15:09 UTC

(This is a problem that occurs in web-based Online, too.)

Comment 4 How can I remove my account? 2019-11-21 13:44:04 UTC

Fix in https://gerrit.libreoffice.org/#/c/83395/ . That is for the collabora-online-4 branch, i.e. the 4.1.x version of the app. Possibly the same fix is good enough for the master branch (4.2.x), too, but there I need to make sure it doesn't break the WOPI-like feature support of web-based Online, which might depend on some quirks in how the code works.

Comment 5 How can I remove my account? 2019-11-21 13:45:16 UTC

I tested with a file name called A#B?C\D&E❤️F🇨🇭G%AAHÖ.doc ...

Comment 6 Commit Notification 2019-11-25 17:12:03 UTC

Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/c806acb157fa501a8be872042b534a2f49641e62

tdf#125755: Fix some URI encoding issues

Comment 7 Michael Meeks 2019-11-28 17:38:59 UTC

Unfortunately there is a bit of a mess here. This fixes iOS and is fine for file:/// unit tests - but seems to break WOPI implementations which use more involved multiple encoding nonsense & seem to expect this. Download-as, Slideshow etc. broke here - so I'll make it Mac specific for now.

Comment 8 Commit Notification 2019-11-28 18:19:16 UTC

Michael Meeks committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/039ca3540e84498e24da33cdea51c70163aafca8

tdf#125755: specialize reduced decoding for mobile apps.

Comment 9 Nicolas Christener 2019-12-13 16:56:24 UTC

Works as expected now.

Tested with 4.2 (25) on iOS 13.3.x

This issue can be closed as fixed.

Thanks a lot to the Collabora team and especially Tor for taking care ot this!