Bug 125803

Summary: UI: checkbox in menu not updated immediately when set with space bar (gtk3)
Product: LibreOffice Reporter: Cor Nouws <cno>
Component: LibreOfficeAssignee: Caolán McNamara <caolan.mcnamara>
Status: VERIFIED FIXED    
Severity: normal CC: caolan.mcnamara, cno, raal, xiscofauli
Priority: medium    
Version: 6.4.0.0.alpha1+   
Hardware: All   
OS: Linux (All)   
Whiteboard: target:6.3.0.1 target:6.4.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103182    

Description Cor Nouws 2019-06-08 15:09:30 UTC 
start Writer
with shortcuts: View > Toolbars (Alt+V+T)
arrow right + down, to e.g. Arrows
hit space bar
  > toolbar appears
  > tick box is not set
ESC (close menu)
open menu ((Alt+V+T)
  > tick box is set

Noticed in Version: 6.3.0.0.alpha1+
Build ID: 77ae0abe21f672cf4b7d2e069f1d40d20edc49a7
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-05-31_15:33:33
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 raal 2019-06-10 20:48:38 UTC 
Confirm with Version: 6.3.0.0.beta1+
Build ID: 4abdaf4afb2245d404f6709124b3c627b07b8a3c
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;
Comment 2 Xisco Faulí 2019-06-11 09:11:16 UTC 
This is only GTK3, the space bar doesn't work in GEN nor GTK.
@Caolán, should we disable the spacebar action in GTK3 as GEN and GTK do ?
Comment 3 Caolán McNamara 2019-06-14 12:57:01 UTC 
checking gtk3-demo the example menus there update their state on spacebar, I guess we're missing something there to do that too
Comment 4 Caolán McNamara 2019-06-22 19:47:10 UTC 
yeah, correct way to do this is probably quite a bit of work, but deactivating the menu hierarchy regardless of what got activated is easy. Won't do anything in the unity case though, but that's a goner I think.
Comment 5 Commit Notification 2019-06-23 14:39:12 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/b85067dd005bdc54cf820af1987f287f4f719c58%5E%21

tdf#125803 deactivate the menu regardless of menu item type

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-06-23 14:56:19 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/92cf12ea025dfda642809d297a015131c1925052%5E%21

tdf#125803 deactivate the menu regardless of menu item type

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2019-06-25 09:59:46 UTC 
Verified in

Version: 6.4.0.0.alpha0+
Build ID: 52800731baf9fcb88e54d60de5585640c8f97f7b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Now the menu is closed when pressing the space bar.

@Caolán, thanks for fixing this issue!