Bug 126059

Summary: customize toolbar function list didn't use full height
Product: LibreOffice Reporter: andreas_k <kainz.a>
Component: UIAssignee: Caolán McNamara <caolan.mcnamara>
Status: RESOLVED FIXED    
Severity: normal CC: 79045_79045, caolan.mcnamara, kainz.a, sumitcn25
Priority: medium Keywords: bibisected, bisected, regression
Version: 6.4.0.0.alpha1+   
Hardware: All   
OS: Windows (All)   
Whiteboard: target:6.4.0 target:6.3.0.1
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 125811    
Attachments: Customize Toolbars

Description andreas_k 2019-06-23 19:34:58 UTC 
Description:
Tools -> customize -> Toolbars Function show the list of commands within the Target, but on windows (It's only on windows an bug) the height of the list is not 100% on bottom there in the list ended (see attachment).

Steps to Reproduce:
1. Menubar
2. Tools
3. Costomization
4. Toolbars tab

Actual Results:
wrong height of the Function list

Expected Results:
List should be the same than on the left.


Reproducible: Always


User Profile Reset: No



Additional Info:
Bug is only on windows
Comment 1 andreas_k 2019-06-23 19:36:17 UTC 
Created attachment 152362 [details]
Customize Toolbars

in LibreOffice 6.2.x there is no bug, in LibreOffice 6.3 beta this bug is visible only on windows.
Comment 2 Roman Kuznetsov 2019-06-23 19:41:28 UTC 
confirm in

Версия: 6.3.0.0.beta2 (x64)
ID сборки: 6c6edded7133daf2d8d0b2ea7ae25b8109c5c064
Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: по умолчанию; VCL: win; 
Локаль: ru-RU (ru_RU); UI-Language: ru-RU
Calc: threaded

I'll try bisect it
Comment 3 Roman Kuznetsov 2019-06-23 20:52:45 UTC 
I bisected it

$ git bisect good 85634202f555f743c29111fcc225e9c5c981e514 is the first bad commit
commit 85634202f555f743c29111fcc225e9c5c981e514
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Mon Mar 11 08:58:51 2019 -0700

    source 3a42ee3284df7020ef111293a4d11148c1bf3a50


https://gerrit.libreoffice.org/#/c/68906/

Caolan, please look at it
Comment 4 Commit Notification 2019-06-24 13:51:35 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/8f7e5883d66afbf6c04ca64cd6ec86d209bd124e%5E%21

Resolves: tdf#126059 extra empty widget is visible

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2019-06-24 19:21:03 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/d23593cbbbe1e051e0b926faa2bf3a4072e4636b%5E%21

Resolves: tdf#126059 extra empty widget is visible

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.