Bug 126089

Summary: DOCX with Text Box shapes not rendering entirely
Product: LibreOffice Reporter: Devon Powell <Devon.Powell>
Component: LibreOfficeAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: aron.budea, libreofficebugs, libreoffice, raal, telesto
Priority: medium Keywords: bibisected, bisected, regression
Version: 6.0.0.3 release   
Hardware: All   
OS: Windows (All)   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=114212
https://bugs.documentfoundation.org/show_bug.cgi?id=138282
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 104449    
Attachments: Second page of this document is partially rendering.
printscreen from word2010
The example file in Word 2013 and current 7.2 master
The example file in Word 2013 and Writer 7.4 master

Description Devon Powell 2019-06-25 14:12:27 UTC
Description:
Only first page of the attached document is rendering correctly, second page is partially rendering.

Steps to Reproduce:
1.Open attached document with LibreOffice 6.2.4
2.Observe second page is just partially rendering


Actual Results:
Second page is just partially rendering.


Expected Results:
The document renders entirely.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Devon Powell 2019-06-25 14:13:58 UTC
Created attachment 152397 [details]
Second page of this document is partially rendering.
Comment 2 raal 2019-06-25 19:30:49 UTC
Created attachment 152402 [details]
printscreen from word2010
Comment 3 raal 2019-06-25 19:32:39 UTC
Confirm with Version: 6.3.0.0.beta2+ (x86)
Build ID: 3a2d31cdd684b42b0921917dc7a8c27d6f6bb25a
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 

works in Version: 4.2.0.0.alpha1+
Build ID: fc8f44e82de4ebdd50ac5fbb9207cd1a59a927e3
regression
Comment 4 raal 2019-06-25 19:45:05 UTC
This seems to have begun at the below commit.
Adding Cc: to Michael Stahl; Could you possibly take a look at this one? Thanks
 02f131af9a9d1f139b99337f072848a2f7d001e2 is the first bad commit
commit 02f131af9a9d1f139b99337f072848a2f7d001e2
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Mon Dec 18 13:37:09 2017 -0800

    source bdcbf601410f29642aa27e2b8fab312f929d569f

author	Michael Stahl <mstahl@redhat.com>	2017-12-18 21:38:48 +0100
committer	Michael Stahl <mstahl@redhat.com>	2017-12-18 22:19:17 +0100
commit bdcbf601410f29642aa27e2b8fab312f929d569f (patch)
tree d6fa73125f91aac90a74c09528ab225de558f893
parent a7c772566bb8ac6a088b808cf0ef550e7b06560b (diff)
tdf#114212 sw: fix layout of as-char anchored text-frame of shape
Comment 5 Timur 2020-04-02 12:12:11 UTC
Repro 7.0+.
Comment 6 NISZ LibreOffice Team 2021-02-08 07:42:32 UTC
Created attachment 169571 [details]
The example file in Word 2013 and current 7.2 master

Still a problem in:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-GB
Calc: CL
Comment 7 Gabor Kelemen (allotropia) 2022-02-10 00:22:50 UTC
Created attachment 178181 [details]
The example file in Word 2013 and Writer 7.4 master

Much improvement here in 7.2 with:
 62dcbe78332e7b46036b8a386bf338c9d6d81807 is the first bad commit
commit 62dcbe78332e7b46036b8a386bf338c9d6d81807
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Tue Jun 15 16:49:28 2021 -0700

    source a771262cfcfc358269dc50dfa10f9e497e7d8deb

    source a771262cfcfc358269dc50dfa10f9e497e7d8deb
    source 9b81036c87b52edc2ce44813b31be425bc12ee1d
    source af8d12bd3a73381dfdfad92b63306369a665a2d7
    source 89e7341025b607491c90efdb74708e63d875c1e5

of which 
https://git.libreoffice.org/core/+/89e7341025b607491c90efdb74708e63d875c1e5

author	Justin Luth <justin_luth@sil.org>	Thu May 27 14:32:54 2021 +0200
committer	Justin Luth <justin_luth@sil.org>	Fri May 28 17:06:17 2021 +0200

tdf#142404 sw compat layout: ignore blank size only on one-liners

Seems to be the likely fix. Before this the 3 columns were rendered as well (unlike in the original report), but started at the bottom of the first page and they mostly fell between the two.

But still not perfect:
- Top left and right colored squares are grouped shapes, appearing below the pages top margin. In Word they have negative margin so the top of the group is not visible. Writer does not seem to support negative margin for grouped shapes.
- First page center column the blue, centered non-bulleted "Test document" texts are losing their style setting inside a grouped shape so they are not blue and left aligned in Writer
(these would be better split out as individual bugs with minimal examples)