| Summary: | FILEOPEN DOCX Two pages document containing WMF images appears as one page | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
| Component: | Writer | Assignee: | Gabor Kelemen (allotropia) <kelemeng> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | kelemeng, nemeth, vmiklos, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, filter:docx, regression |
| Version: | 6.1.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=138515 https://bugs.documentfoundation.org/show_bug.cgi?id=138455 |
||
| Whiteboard: | target:6.4.0 target:6.3.0.2 target:6.2.6 target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Example file from Word with WMF images
The same example file from Word with JPG images Screenshot of the two documents in Word – no difference Screenshot of the two documents in LO 6.1 alpha right before the suspected commit – no difference Screenshot of the two documents in LO 6.1 alpha at the suspected commit. |
||
|
Description
NISZ LibreOffice Team
2019-07-09 13:27:17 UTC
Bibisected using bibisect-win32-6.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=edda1e5fc8113aa4744e32f97c96a3cc311485ca Created attachment 152681 [details]
Example file from Word with WMF images
Created attachment 152682 [details]
The same example file from Word with JPG images
Created attachment 152683 [details]
Screenshot of the two documents in Word – no difference
Created attachment 152684 [details]
Screenshot of the two documents in LO 6.1 alpha right before the suspected commit – no difference
Created attachment 152685 [details]
Screenshot of the two documents in LO 6.1 alpha at the suspected commit.
The file with WMF images appears on one page, now with actual image content shown.
Adding CC to: Miklos Vajna Bibisected using bibisect-win32-6.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=edda1e5fc8113aa4744e32f97c96a3cc311485ca author Miklos Vajna <vmiklos@collabora.co.uk> 2018-04-20 16:32:00 +0200 Committer Miklos Vajna <vmiklos@collabora.co.uk> 2018-04-20 21:04:35 +0200 Summary: DOCX import: lazy-read images without external headers Reproduced in Version: 6.4.0.0.alpha0+ Build ID: 7a0164f0d82d91e2ac481d74cdacfe9a7ad6080f CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Adding Cc: to Miklos Vajna Proposed patch: https://gerrit.libreoffice.org/#/c/75599/ Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/184a4771dad448a37f80b29bc62ad62e0a6a4bb6%5E%21 tdf#126310 Disable lazy loading of WMF images It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Gabor Kelemen committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/1c04b5c97ca3b12e52ec55572da77f7b6636e34c%5E%21 tdf#126310 Disable lazy loading of WMF images It will be available in 6.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 6.4.0.0.alpha0+ Build ID: ed2107f0488887528d8e49135d3270705f389ed5 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Gabor, thanks for fixing this issue!! Could it be possible to have a unittest for this fix ? Gabor Kelemen committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/f88d51e1f27896e5339033671bac158d2436abcf%5E%21 tdf#126310 Disable lazy loading of WMF images It will be available in 6.2.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1238ca8d100c107656b707ed3a6b662f0a1867fb Revert "tdf#126310 Disable lazy loading of WMF images" It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |