| Summary: | Wrong rendering with Greyscale TIF with no / transparent background | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | joachim_liedtke |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, cno, raal |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| Whiteboard: | target:6.4.0 target:6.3.1 target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 126152 | ||
| Attachments: |
Greyscale TIF with transparent background
printscreen from LO 6.4 and LO 4.1 |
||
|
Description
joachim_liedtke
2019-07-18 09:20:55 UTC
Created attachment 152854 [details]
Greyscale TIF with transparent background
Confirm with Version: 6.4.0.0.alpha0+ Build ID: 47a774fbef8c224e4853de3fdd0230b9442bb716 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Created attachment 152895 [details]
printscreen from LO 6.4 and LO 4.1
compare LO 4.1 and LO 6.4 - it's wrong in both versions, but worse in 6.4
(In reply to raal from comment #3) > Created attachment 152895 [details] > printscreen from LO 6.4 and LO 4.1 > > compare LO 4.1 and LO 6.4 - it's wrong in both versions, but worse in 6.4 Bisected to 75b3cd34182fc8057d3c402a7c4435b2e61e60a0 is the first bad commit commit 75b3cd34182fc8057d3c402a7c4435b2e61e60a0 Author: Matthew Francis <mjay.francis@gmail.com> Date: Sat Sep 5 20:35:12 2015 +0800 source-hash-98a61a2ae109f3d72940274ceafcf3e84d79aa0b commit 98a61a2ae109f3d72940274ceafcf3e84d79aa0b Author: Caolán McNamara <caolanm@redhat.com> AuthorDate: Thu Aug 22 15:06:10 2013 +0100 Commit: Caolán McNamara <caolanm@redhat.com> CommitDate: Thu Aug 22 15:08:05 2013 +0100 Resolves: fdo#68275 Grayscale TIFF is imported as white this reverts 6c719c1585eb1a2dbab86cc73ff871da41765981 "n#615223 local nbyte1 should have been class-level nByte1" which was to fix the use seen in valgrind og the uninitialized nByte1 So additionally remove the use of the uninit nByte1 entirely Adding Cc: to Caolán McNamara bisect just points to location where wrongness changed, there doesn't appear to be a known working state This two byte format seems to be greyscale byte followed by alpha byte, or at least that's what imagemagick seems to do Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/09ad0e78129d4f85fd1b847b35409fd5440ed23c%5E%21 Resolves: tdf#126460 implement reading grayscale+alpha tiff format It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/fda86dd781a80703f06ae1b6056439bafed190a8%5E%21 Resolves: tdf#126460 implement reading grayscale+alpha tiff format It will be available in 6.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8cfad2357f309c8f8aaf11c89722307b5bd704c7 tdf#126460: libtest_filter_tiff: Add unittest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |