| Summary: | Empty cells with formatting not included in sort even though "Include formats" option is checked (see comment 6) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Adalbert Hanßen <adalbert.hanssen> |
| Component: | Calc | Assignee: | Andreas Heinisch <andreas.heinisch> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ilmari.lauhakangas, jmadero.dev, ktc |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 5.0.0.5 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=81501 https://bugs.documentfoundation.org/show_bug.cgi?id=144135 |
||
| Whiteboard: | target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108386 | ||
| Attachments: |
Test case as described, with screenshots and pasted spreadsheets
the spreadsheet as ods-file (iun its final state) Minimal test case |
||
|
Description
Adalbert Hanßen
2019-08-02 15:22:24 UTC
Created attachment 153109 [details]
Test case as described, with screenshots and pasted spreadsheets
Created attachment 153110 [details]
the spreadsheet as ods-file (iun its final state)
@Aldabert - Just a suggestion, in the future keep bug reports much shorter and less of a book than a bulleted list of how to reproduce. I can spend 10 minutes triaging a couple bugs, or spend 30 reading this one ;) Any chance you can summarize your novel into a couple bullets? Thanks :) (In reply to Joel Madero from comment #3) > @Aldabert - > > Just a suggestion, in the future keep bug reports much shorter and less of a > book than a bulleted list of how to reproduce. I can spend 10 minutes > triaging a couple bugs, or spend 30 reading this one ;) Any chance you can > summarize your novel into a couple bullets? > > Thanks :) The bug is still present in the development Version: 6.4.0.0.alpha0+ Build ID: 0fb2927a8fe06e6c3255544b8e4c4c9c0f5a67d3 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-08-27_22:50:23 Locale: de-DE (de_DE.UTF-8); UI-Language: en-US Calc: threaded I don't think that this following numbered form or even one with only ullets to the steps one would be easier to grasp and to reproduce than my original one and probably you would have to read more carefully to understand it, what it is all about (unfortunately this is not a bug of the type to let LO Calc crahs): 1. make a LO Calc document with different line lengths 2. take care that there is at least one column of data which are such that after sorting by this column no row maintains its place 3. assign different character sets, sizes, colours, boldness, slant and the like to whole lines by first marking the line on the left border, then assign the property, 4. sort the whole table by first clicking into the field left to and above A1 and then sort the whole table by the column specified in 2. 5. add information to lines the right of the existing data in some rows. Observe if it inherits the colour, slant, boldness and the like from the left, 6. Also do this for columns for which no row had any data in the original spreadsheet. Expected result: in step 5 and 6 all added fields inherit their formatting properties from the existing part left to them, since the properties were assigned to the whole rows, nut just a part of it. Unfortunately, during sorting only the parts in the data with the minimum rectangle possible to describe all data are sorted. The rest is left as it was before. Thus after sorting, the lines no longer have uniform formatting properties as they had before. This is buggy, since the formatting properties were assigned to the whole lines, not just parts of them. Sorting was not confined to the part of the file with data in it. [Automated Action] NeedInfo-To-Unconfirmed Created attachment 159719 [details] Minimal test case Steps with this test case: 1. Select A1:E10 2. Data - Sort 3. In the Options tab, verify that "Include formats" is checked 4. Sort key Column B Result: the empty cell with yellow background does not move with the sort. Bibisected with Linux 50max repo to https://git.libreoffice.org/core/+/c50d8bf596f527bb53b86dd04da652ed72f2c549%5E!/ "Fix high memory usage when sorting cells in Calc. (fdo#81501) Empty columns were being unnecessarily included in the sorting range which caused extra allocation. This happens when you select the entire sheet to sort. There was already code to skip empty trailing cells in rows but not to skip empty columns." Looks like this small change did not take into account the option "Include formats". Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/774a61afa9fc281290e7bfad4e28c05978b82d73 tdf#126678 - Consider "Include formats" option during sort It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |