| Summary: | FILEOPEN DOCX Numbered list item gets indent setting from next paragraphs footnote | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | davidjames520po, jluth, kelemeng, nemeth, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.2.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=104348 https://bugs.documentfoundation.org/show_bug.cgi?id=118521 |
||
| Whiteboard: | target:6.4.0 target:6.3.1 target:6.2.7 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 109195 | ||
| Attachments: |
Screenshot of the original document side by side in Word and Writer
Example file from Word with footnote added to numbered paragraph Example file from Word with footnote without left indent Example file from Word with footnote without left indent tdf126723.docx: better text for debugging |
||
|
Description
NISZ LibreOffice Team
2019-08-06 09:12:05 UTC
Additional Information: Bibisected using bibisect-win32-6.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=07266e2314fd19dcbf777dadd52d7b826b23c207 author Justin Luth <justin_luth@sil.org> Tue Jul 24 14:49:00 2018 +0300 committer László Németh <nemeth@numbertext.org> Wed Aug 01 11:33:02 2018 +0200 summary: tdf#118521 writerfilter: ContextMargin grouped with Top/Bottom Created attachment 153161 [details]
Screenshot of the original document side by side in Word and Writer
Created attachment 153162 [details]
Example file from Word with footnote added to numbered paragraph
Created attachment 153163 [details]
Example file from Word with footnote without left indent
Created attachment 153164 [details]
Example file from Word with footnote without left indent
Reproduced in Version: 6.4.0.0.alpha0+ Build ID: 967644f09b8b7abe3b86d1647820f14e0196f8b4 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Adding Cc: to Justin Luth Created attachment 153230 [details] tdf126723.docx: better text for debugging Actually, this is for LO 6.2. I don't think it really is a regression. I think it exposed a bug, because the results are illogical. It IS doing a ::finishParagraph on the footnote text - somehow those properties are affecting the prior paragraph (only). proposed fix at https://gerrit.libreoffice.org/77185 tdf#126723 writerfilter::finishParagraph - me, not previous In LO 6.2 commit 480ac84f2f5049fb4337b36f12fd6796e005761b the existing m_xPreviousParagraph was conveniently used to apply the changed properties. I never did like that choice, but despite looking at it, I failed to see that it is set in an inside loop, which means that it was NOT NECESSARILY reset to the current paragaph. So I'm happy to have proof that we should not use m_xPreviousParagraph Too bad it took a full day to actually see that. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/d03c92b93d6ba1808a6641b4aa8cb4aae38058bf%5E%21 tdf#126723 writerfilter::finishParagraph - me, not previous It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/025f17c4247b1c4458192da177648c304a93b949%5E%21 tdf#126723 writerfilter::finishParagraph - me, not previous It will be available in 6.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/df28caa1fc24c6288f4c10854b03612c929ee676%5E%21 tdf#126723 writerfilter::finishParagraph - me, not previous It will be available in 6.2.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 6.4.0.0.alpha0+ Build ID: d9b54924fbfc2eae33c503434b0bfd3619c6a1a6 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Justin Luth, thanks for fixing this issue!! |