Bug 127029

Summary: gtk3: empty spinbuttons don't stay empty when the notebook gets split
Product: LibreOffice Reporter: Caolán McNamara <caolan.mcnamara>
Component: WriterAssignee: Caolán McNamara <caolan.mcnamara>
Status: RESOLVED FIXED    
Severity: normal    
Priority: medium    
Version: 6.3.0.4 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=95927
Whiteboard: target:6.4.0 target:6.3.2
Crash report or crash signature: Regression By:

Description Caolán McNamara 2019-08-19 14:23:21 UTC 
Description:
empty spinbuttons don't stay empty when the notebook gets split

Steps to Reproduce:
1.  open Find & Replace Dialog
2.  type search text in the Find box
3.  type replacement text in the Replace box
4.  hit "format" button to format replace text
5.  select "Without Underlining" in "Font Effects" tab.
6.  hit OK.
7.  notice that other paragraph formatting is being applied, not just "without underlining."

Actual Results:
0.00 appears instead of nothing

Expected Results:
blank, not 0.00


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Caolán McNamara 2019-08-19 15:13:49 UTC 
The difficulty is the desire to have a "blank" entry which is special vs a 0 value, and gtk's desire to reformat the entry on many different routes
Comment 2 Commit Notification 2019-08-19 19:21:31 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/7390c3d4509ccb77f44da5e0eee8e9169026e7d9%5E%21

Resolves: tdf#127029 keep spinbuttons blank if explicit set_text("")

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2019-08-19 19:22:54 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ac44308f4df996033444e9d4687746c5d6b9525b%5E%21

Related: tdf#127029 true was substituted for FALSE

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2019-08-19 20:02:52 UTC 
fixed in master, backport to 6-3 in gerrit. Keep the special "blank" entry blank until the value is changed explicitly
Comment 5 Commit Notification 2019-08-29 07:42:00 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/b29764bab932d1a5a2912c87342b743968360206%5E%21

Resolves: tdf#127029 keep spinbuttons blank if explicit set_text("")

It will be available in 6.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-08-29 08:26:27 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/0417dd10991b0e92b5163167ddba59f1ffe6d73d%5E%21

Related: tdf#127029 true was substituted for FALSE

It will be available in 6.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.