Bug 127038

Summary:	Tabbed toolbar: Unnecessary uno::InsertField redundancy in the "References" option group
Product:	LibreOffice	Reporter:	Leandro Martín Drudi <sanipachenko>
Component:	Writer	Assignee:	Justin L <jluth>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	heiko.tietze, jluth, kainz.a, mentoring
Priority:	low	Keywords:	difficultyMedium, easyHack, skillDesign, topicUI
Version:	6.3.0.4 release
Hardware:	All
OS:	All
Whiteboard:	target:24.2.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	107237
Attachments:	The "More fields" button appears 3 times in the same group. The "More fields" button appears 3 times in the same group. Placing only the buttons and adding, perhaps, some other field not directly accessible, can help eliminate redundancy and also take the group so that the tab does not appear empty.

Description Leandro Martín Drudi 2019-08-19 21:44:05 UTC

Description:
In the References tab of the omnibarra (notebook bar) you have redundant and unnecessary options considering the use of the main button.
I think it is more useful to repeat what is available in the "Insert" tab or, just put the buttons to insert specific fields and an "Insert field" button, omitting the button with the menu.

Steps to Reproduce:
1. In Notebook bar visible
2. Clic on References tab


Actual Results:
Too many buttons for the same use.

Expected Results:
A more orderly and less redundant group of options.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I propose to include all the menu buttons and even some other to insert another field and the "Other fields" button and keep the menu button to "Insert" because it has a greater number of options and this option would take up too much space unlike References that have few options and need to be fuller.

Comment 1 Leandro Martín Drudi 2019-08-19 21:45:55 UTC

Created attachment 153520 [details]
The "More fields" button appears 3 times in the same group.

Comment 2 Leandro Martín Drudi 2019-08-19 21:47:33 UTC Comment hidden (obsolete)

Created attachment 153522 [details]
The "More fields" button appears 3 times in the same group.

Comment 3 Leandro Martín Drudi 2019-08-19 21:49:08 UTC

Created attachment 153523 [details]
Placing only the buttons and adding, perhaps, some other field not directly accessible, can help eliminate redundancy and also take the group so that the tab does not appear empty.

Comment 4 Leandro Martín Drudi 2019-08-19 21:50:53 UTC Comment hidden (off-topic)

When I attached the first image I threw this error (that's why it appears twice).


DBD::Pg::db do failed: ERROR:  could not serialize access due to concurrent update [for Statement "DELETE FROM tokens WHERE token = ?"] at Bugzilla/Token.pm line 383.
	Bugzilla::Token::delete_token("v82KPj5PIn") called at /srv/bugzilla/bugzilla-5.0.4/attachment.cgi line 524
	main::insert() called at /srv/bugzilla/bugzilla-5.0.4/attachment.cgi line 87

I don't know how to report to the webmaster

Comment 5 Dieter 2019-09-15 04:50:37 UTC

(In reply to Leandro Martín Drudi from comment #3)
> Created attachment 153523 [details]
> Placing only the buttons and adding, perhaps, some other field not directly
> accessible, can help eliminate redundancy and also take the group so that
> the tab does not appear empty.

+1 for this proposal, but I would put "more fields" in second row (just for logical reasons).

Comment 6 Heiko Tietze 2019-09-17 07:28:22 UTC

I would remove "More fields" from the tab as it makes the whole dropdown obsolete.

@Leandro: You can hide comments and attachments yourself https://wiki.documentfoundation.org/QA/BugTriage#Comment_tags

Comment 7 Heiko Tietze 2021-05-18 08:43:13 UTC

Recommendation given in comment 6.

We have .uno:InsertField the single button and .uno:InsertFieldCtrl, the menu which includes the button. This menu is also located on several toolbars and we rather remove the individual button from the Notebookbar. Search for this command in the */notebookbar.ui files.

Comment 8 Justin L 2023-06-16 18:00:50 UTC

repro 24.2+

Comment 9 Commit Notification 2023-10-17 23:43:04 UTC

Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/efafe9b1771b1c20bf27345cafbeb9e1b9e635eb

tdf#127038 sw notebookbar: remove redundant "more fields"

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.