| Summary: | Bottom toolbar isn't displayed on mobile | ||
|---|---|---|---|
| Product: | LibreOffice Online | Reporter: | OrangeDev <tuananh.hedspi> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | aron.budea, me |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Toolbar-down in the new version
Bottom toolbar isn't displayed after click some toolbar icon |
||
|
Description
OrangeDev
2019-08-22 07:15:40 UTC
If you scroll down with the v / ^ buttons on top of iOS virtual keyboard, does the toolbar appear then? I don't have iPhone simulator. But i scroll down in the below devices but the toolbar doesn't appear: - iPhone 7, iOS v12.3.1, Safari - iPhone X, iOS v13.0, Safari - Galaxy Note 8, Android9, SamSung Internet Browser v9.4.00.45 - Change user-agent of Firefox on Mac-OS to iPhone/Safari 12.1.1 - Change user-agent of Firefox on Mac-OS to Android phone/Firefox 68 - Change user-agent of Firefox on Mac-OS to Android phone/Chrome 76 Created attachment 153656 [details]
Toolbar-down in the new version
In my debug in old version of bundle.js, createToolbar() method has the following code:
if (_inMobileMode()) {
$("#mobile-edit-button").show();
initMobileToolbar(toolItems)
} else {
$("#toolbar-down").show();
initNormalToolbar(toolItems)
}
But in the latest image, It become the followng code
function createToolbar() {
if (_inMobileMode()) {
$("#mobile-edit-button").show()
} else {
$("#toolbar-down").show();
initNormalToolbar()
}
}
The initMobileToolbar() method have been removed.
So, if i add "$("#toolbar-down").show();" code into click event of #mobile-edit-button.
if (L.Browser.mobile) {
var button = $("#mobile-edit-button");
button.show();
button.off("click");
var that = this;
button.on("click", function() {
button.hide();
that._enterEditMode("edit");
that.fire("editorgotfocus");
if (!(window.ThisIsTheiOSApp || window.ThisIsTheAndroidApp)) that.focus();
$("#toolbar-down").show();
});
this._enterReadOnlyMode("readonly")
}
#toolbar-down will be displayed as attached file in the previous comment.
This is a non-related question, save icon in the toolbar-down was removed?
Created attachment 153726 [details]
Bottom toolbar isn't displayed after click some toolbar icon
After i used above method, bottom toolbar is shown in the edit screen.
But when i use some icon in the bottom, screen auto zoom-out and the toolbar isn't displayed.
Please check attached LOOL_toolbar.mp4 file.
Let's set the issue to confirmed. There are potentially multiple bugs together (eg. when LOOL is integrated into an app like Nextcloud/ownCloud, it can also cause the view to extend below the end of screen, and hide some content in the bottom). LOOLWSD master (git hash: f7079c96) LOKit LibreOfficeDev 6.4.0.0.alpha0 (git hash: 61b757f) Just tried with LOOLwsd 6.4.0 and LOkit 6.4.1.1.0: Safari on iPad won't show both the bottom toolbar and the keyboard. Almost all buttons remain grey. This should be working fine in recent builds. |