| Summary: | Selectable text and links in dialogs don't have indication of focused state | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Mike Kaganski <mikekaganski> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | trivial | CC: | caolan.mcnamara, xiscofauli |
| Priority: | lowest | Keywords: | bibisected, bisected, regression |
| Version: | 6.2.0.0.alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.5.0 target:6.4.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Mike Kaganski
2019-08-25 13:51:56 UTC
Reproduced in Version: 6.5.0.0.alpha0+ Build ID: b9d6ea1dd7541c4bd866571f9e3f0aa894687c07 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Regression introduced by: author Caolán McNamara <caolanm@redhat.com> 2018-09-19 15:35:36 +0100 committer Caolán McNamara <caolanm@redhat.com> 2018-09-20 09:56:15 +0200 commit da9a539999fc8ae47a78542ce646005f3a9be868 (patch) tree 955f1361b5379da8bf24ab23e4cabdc3dc260745 parent 3f73733f7df6393be773e66e445eb0a86e9a9377 (diff) use can-focus for TB_TABSTOP|WB_NOTABSTOP, not editable https://cgit.freedesktop.org/libreoffice/core/commit/?id=da9a539999fc8ae47a78542ce646005f3a9be868 Bisected with: bibisect-linux64-6.2 Adding Cc: to Caolán McNamara The link issue half of this is a regression from... commit 7eb37a422f2e66bc177d72404c53659a248661ca Date: Mon Aug 12 11:35:51 2019 +0200 tdf#118856 vcl: avoid flicker in the about dialog the RequestDoubleBuffering line in vcl/source/window/aboutdialog.cxx does "flickering" under windows return if that's removed ? by which I mean its just this dialog has an issue with links, not the rest of them > or cursor (vertical bar) shown and blinking indicating the focus;
Blinking cursors can be blinding migraine triggers. Standard LibreOffice for Mac does not allow users to disable these cursors. LibreOffice for Windows is not supported in WINE. At this point I use a combination of NeoOffice and LibreOffice NBC.
As long as there's no way for Mac users to disable these cursors, some of us won't be able to see the dialogues with these cursors.
If we can disable these cursors, we won't be able to see the focus.
A non-blinking focus rectangle may be a better option.
I imagine what the bisect picked up on was that before da9a539999fc8ae47a78542ce646005f3a9be868 the textview widget was skipped in the tab order if it was readonly, which isn't something I'd like to change back to. We could turn off can-focus in aboutbox.ui for version if we wanted to go back to skipping the widget in the tab traversal. I feel we do want to be able to tab into it, but want some visual feedback we're in there and ideally select all for easy copy and paste Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/504d9e75f663497e7ba08ea4124c8a1b06d658ce tdf#127148 select-all on tabbing into version box in help->about It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/8de197a982f6b588ee65ab5e2f4bdb879e73e51f tdf#127148 select-all on tabbing into version box in help->about It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. A polite ping to Caolán McNamara: Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing? Thanks Currently the version box now gives a visual indication that it has the focus, but the link button focus is still mis-rendered IIUC I think with the new help dialog the issue is moot now |