Bug 127663

Summary:	Undo font resize needs multiple undo actions
Product:	LibreOffice	Reporter:	Nicolas Christener <contact>
Component:	iOS Editor	Assignee:	Jan Holesovsky <kendy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	xiscofauli
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	iOS
Whiteboard:	target:6.4.0
Crash report or crash signature:		Regression By:
Attachments:	Video demonstrating the issue

Description Nicolas Christener 2019-09-20 13:18:43 UTC

Description:
Resizing the font size of some text works well but undoing such a change needs multiple undo actions.

Steps to Reproduce:
1. Create a document with the iOS app
2. Enter some text and resize the font size e.g. from 14pt to 28ot
3. Tab undo once

Actual Results:
Nothing visibily happens.

Expected Results:
The font size should go back to the last size.


Reproducible: Always


User Profile Reset: No



Additional Info:
If I tap some more time on the undo button it will work at some point.

In my tests this seems to happen after the 8th try.

Comment 1 Nicolas Christener 2019-09-20 13:21:33 UTC

Created attachment 154322 [details]
Video demonstrating the issue

Comment 2 Jan Holesovsky 2019-09-23 11:23:42 UTC

Have a fix here:

https://gerrit.libreoffice.org/#/c/79400/
https://gerrit.libreoffice.org/#/c/79401/

Comment 3 Commit Notification 2019-09-26 07:46:38 UTC

Jan Holesovsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/311e93fb90cd9480368eeabf2e5adc264af30eed

tdf#127663: Don't emit 'uno .uno:FontHeight ...' multiple times.

Comment 4 Jan Holesovsky 2019-09-26 09:36:46 UTC

Fixed.