Bug 127711

Summary:	A runtime-switch for the MiniCrashDump
Product:	LibreOffice	Reporter:	Juergen Funk (CIB) <juergen.funk_ml>
Component:	LibreOffice	Assignee:	Juergen Funk (CIB) <juergen.funk_ml>
Status:	RESOLVED FIXED
Severity:	normal	CC:	oliver.brinzing, thb, xiscofauli
Priority:	medium
Version:	6.4.0.0.alpha1+
Hardware:	All
OS:	All
Whiteboard:	target:6.4.0 target:6.5.0 target:6.4.0.1
Crash report or crash signature:		Regression By:

Description Juergen Funk (CIB) 2019-09-23 09:19:38 UTC

With this switch should be possible for on/off the creation of the:
 - Dump.ini 
 - crashdumpfile.dmp

Then it be possible, for define at the compile-time, what the state the switch have, default is ON

For short client-test need a environment variable for set it ON, only when the switch have the state OFF. 

For this feature need a improvment of the CrashReporter-Class, for simpler handling of the new switch.

Comment 1 anwar 2019-09-23 09:51:56 UTC Comment hidden (spam)

To analyze a minidump:-
->Open Visual Studio.
->On the File menu, click Open Project.
->Set Files of type to Dump Files, navigate to the dump file, select it, and ->click Open.
->Run the debugger.

https://www.vtpeanutbutter.com/mcdvoice/

Comment 2 Juergen Funk (CIB) 2019-09-24 06:14:42 UTC

In soffice.ini (sofficerc) the new entry "CrashDumpEnable" default is "true"

The compile-time-switch is "--disable-crashdump", then set the
switch to "false"

 - when "CrashDumpEnable" is false then the Dump.ini and the dump-file 
   are not written
 - when the entry "CrashDumpEnable" is missing, in this case is the
   default true, too
 - the checkbox under Options-General "Send crash reports to ..."
   is deactive and shows off (only view, not change the config)

The environment variable is "CRASH_DUMP_ENABLE" when set to any char,
then the switch "CrashDumpEnable=false" are overrules with true
and the Dump.ini and dump-file are write

Here gerrits
https://gerrit.libreoffice.org/#/c/79272
https://gerrit.libreoffice.org/#/c/79273

Comment 3 Commit Notification 2019-10-02 07:44:25 UTC

Juergen Funk committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2215be5268a646d3cc7d138a0184c6826585b7fb

tdf#127711 - A runtime-switch for the MiniCrashDump

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Thorsten Behrens (allotropia) 2019-10-10 09:17:34 UTC

Looks fixed to me.

Comment 5 Commit Notification 2019-11-20 10:44:01 UTC

Juergen Funk committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/73524467b9a6a7c4e6d5173aba79d80632ef46e2

tdf#127711 Fix msi-soffice.ini CrashDumpEnable-entry

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 6 Commit Notification 2019-11-22 13:32:31 UTC

Juergen Funk committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/1908393e7861f45aea616a192059ccbd9b62b5a4

tdf#127711 Fix msi-soffice.ini CrashDumpEnable-entry

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.