Bug 127909

Summary:	Certificate path dialog doesn't show all profiles and selects wrong one
Product:	LibreOffice	Reporter:	Jan-Marek Glogowski <glogow>
Component:	UI	Assignee:	Jan-Marek Glogowski <glogow>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	medium
Version:	6.4.0.0.alpha1+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=125553 https://bugs.documentfoundation.org/show_bug.cgi?id=125636
Whiteboard:	target:6.4.0
Crash report or crash signature:		Regression By:

Description Jan-Marek Glogowski 2019-10-01 13:50:17 UTC

Description:
This is somewhat of an extension of bug 125553. The dialog has multiple UI problems / bugs, which makes debugging other certificate based bugs even harder:

* It doesn't reflect the currently selected path correctly and always selects the first entry on open. This does not only affect the row selector, but also the radio item. This really had me wondering what's going on, when I needed to switch the profile.
* The "Add" button is IMHO wrongly named. "Instead" of adding an entry to the list, it allows the user to manually select a directory, which contains the NSS certificate databases. This is represented as the "Manual" entry in the list, so its not named that wrong. But you can't have multiple entries and normally there also should be some "Remove" action complementing the "Add", which isn't needed in this case.
* It doesn't show all Mozilla profiles, just existing default ones.

As an additional minor nuisance, LO doesn't keep the manual selection, if the user selects a Mozilla profile. IMHO LO should offer the last manual selection at least while it's running for ease of usage. Better would be to store the value in some variable, independent of the real user selection.

Steps to Reproduce:
1. Open "Tools" -> "Options..." -> "Security" -> "Certificate"
2. Select a non-first profile or add a manual one
3. Observe the various problems from the description.

Actual Results:
The bugs in the description are observable.

Expected Results:
None of the described bugs happen.

Reproducible: Always

User Profile Reset: No

Additional Info:

Comment 1 Jan-Marek Glogowski 2019-10-01 15:47:36 UTC

There is now a bunch of patches:

https://gerrit.libreoffice.org/79975 tdf#127909 rename cert path dialogs' Add button
https://gerrit.libreoffice.org/79976 tdf#127909 refactoring of the cert path dialog
https://gerrit.libreoffice.org/79977 tdf#127909 don't always select the first entry
https://gerrit.libreoffice.org/79978 tdf#127909 list all mozilla profiles
https://gerrit.libreoffice.org/79979 tdf#127909 save manually selected certificate path

Comment 2 Commit Notification 2019-10-23 08:22:08 UTC

Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e3c4b919bdef1dfc8d756425bee099ff7f2e1bb5

tdf#127909 rename cert path dialogs' Add button

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 3 Commit Notification 2019-10-23 08:27:48 UTC

Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/162629610dc07f0ed4e15aeed9bd4cad6bea79d1

tdf#127909 refactoring of the cert path dialog

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Commit Notification 2019-10-23 08:27:54 UTC

Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/aceab9cbf10486d2179d016b36511d907d402825

tdf#127909 don't always select the first entry

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 5 Commit Notification 2019-10-23 08:34:50 UTC

Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/adbaa625acc14e2b814cf5d88267889e6193145f

tdf#127909 list all mozilla profiles

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 6 Commit Notification 2019-10-23 08:58:45 UTC

Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/eca31344795f7dca5b3407c56ab240c11a97c58f

tdf#127909 save manually selected certificate path

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 7 Commit Notification 2019-10-23 11:55:42 UTC

Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/978fffefb15078d52be66463834c8b19ad78af4b

tdf#127909 follow the NSSInitializer selection

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.