| Summary: | configure.ac has a couple issues (patch attached) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | David L. Craig <dlc.usa> |
| Component: | Installation | Assignee: | David L. Craig <dlc.usa> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | m.weghorn, serval2412, xiscofauli |
| Priority: | medium | Keywords: | patch |
| Version: | 6.3.2.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.4.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Patch against configure.ac | ||
|
Description
David L. Craig
2019-10-17 03:32:11 UTC
Created attachment 155047 [details]
Patch against configure.ac
Hello David, Thanks for filling this bug. Could you please submit the patch to gerrit so developers can review it ? < https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch > Michael: thought you might be interested in this one since it concerns kde/qt. David: I didn't see the patch but the first prerequisite is license part. We can't integrate your patch if you don't provide required license statement. This patch, already attached, is against 1 file, 8 lines, 10 character deletions/replacements. Do I really need to jump through these hoops? (In reply to David L. Craig from comment #4) > This patch, already attached, is against 1 file, 8 lines, 10 character > deletions/replacements. Do I really need to jump through these hoops? I can understand you don’t want to bother about gerrit account so i may submit the patch myself but IMHO at least you should do the license part since i’ll quote you in the commit. Sigh. Very well, in my copious free time--I'll start now (maybe it's more trivial than I'm thinking)... it’s just about sending an email to a specific address with: - a specific subject - a block of text in object details here: see https://wiki.documentfoundation.org/Development/Developers I’d be quite astonished it takes more than 5 min. So what is the developer's list email address? Okay, I sent it to that list, signed with my PGP-compliant key. Let me know if you need anything else. i give up ok I had just read your first reply Is there a problem? I submitted the patch here: https://gerrit.libreoffice.org/#/c/81005/ Michael: put you in cc as you may have seen. Thanks for your patch, David. Julien, thanks for submitting it to Gerrit, looks good to me. Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/06b01f73a2d0cc5b6a1c86942e28b1ce7b37bd91 tdf#128189: fix couple issues in configure.ac It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Let's put this one to FIXED. |