| Summary: | Area Style/Filling dropdown from Image toolbar doesn't work | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Gerhard Weydt <gerhard.weydt> |
| Component: | Draw | Assignee: | Katarina Behrens <bubli> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | bubli, buzea.bogdan, ekberg_8, heiko.tietze, philipz85, raykowj, telesto, xiscofauli |
| Priority: | medium | ||
| Version: | 5.3.3.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=123804 https://bugs.documentfoundation.org/show_bug.cgi?id=129008 https://bugs.documentfoundation.org/show_bug.cgi?id=143567 |
||
| Whiteboard: | target:7.3.0 target:7.2.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103223 | ||
| Attachments: | showing the difference between toolbar and sidebar | ||
|
Description
Gerhard Weydt
2019-11-05 23:11:11 UTC
Reproduced in Version: 6.5.0.0.alpha0+ Build ID: d6e2d624a124454fa4ac80cb30a924571a609101 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Heiko, anyone from the UX team that might be interested in fixing this issue ? Not sure about the meta blocker... Adding also Jim as he did some work around this topic. It's beyond my skills.
In svx/source/tbxctrls/fillctrl.cxx the function SvxFillToolBoxControl::StateChangedAtToolBoxControl() receives SID_ATTR_FILL_BITMAP; there is no SID_ATTR_FILL_PATTERN defined.
Pattern and Bitmaps seems to be handled similar, see for example svx/source/sidebar/area/AreaPropertyPanelBase.cxx AreaPropertyPanelBase::Update()
case eFillStyle::BITMAP:
case eFillStyle::PATTERN:
{
...
if(pSh && pSh->GetItem(SID_BITMAP_LIST) && eXFS == BITMAP)
{
else if(pSh && pSh->GetItem(SID_PATTERN_LIST) && eXFS == PATTERN)
{
...
Maybe Bubli knows whether this is easy to solve or just not implemented yet.
Katarina Behrens committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c1a8ff837e3e369561150c0022c6ab02aab27c2c tdf#128612: Support applying pattern fill from toolbar It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 123804 has been marked as a duplicate of this bug. *** Katarina, I tested if the bug is fixed and I notice this: In Version: 7.3.0.0.alpha0+ / LibreOffice Community i create a shape - Area - Pattern and choose a pattern, but the toolbar still shows Bitmap instead of Pattern. It's the latest update to 7.3. Please could you test it? 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 612d5b1a04fe022a34018d901bb9b052791d54e5 CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded *** Bug 131772 has been marked as a duplicate of this bug. *** *** Bug 103229 has been marked as a duplicate of this bug. ***
> In Version: 7.3.0.0.alpha0+ / LibreOffice Community i create a shape - Area
> - Pattern and choose a pattern, but the toolbar still shows Bitmap instead
> of Pattern. It's the latest update to 7.3.
Ouch ...
It works when you apply shape fill via sidebar > area property panel. The toolbar picks up pattern fill correctly.
It doesn't work [initially] via Format > Area or equivalent context menu. The left listbox in toolbar shows 'Bitmap' (wrong) but the right listbox has the list of patterns (correct)
Please open a new bug. Meanwhile, use sidebar as a workaround
The dropdown from toolbar is working well now. Tested with Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 612d5b1a04fe022a34018d901bb9b052791d54e5 CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded For the the difference between toolbar and sidebar I will open a new bug soon. Katarina Behrens committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/a7062af6bfb821c5b8e7d110476332d84d17f624 tdf#128612: Support applying pattern fill from toolbar It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |