| Summary: | Help button in *dialog.ui does not send to the right Help page | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Olivier Hallot <olivier.hallot> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, xiscofauli |
| Priority: | medium | ||
| Version: | 6.3.3.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.5.0 target:6.4.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Olivier Hallot
2019-11-28 00:14:52 UTC
Confirmed in: Version: 6.3.3.2 Build ID: 1:6.3.3-0ubuntu0.18.04.1~lo1 CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-GB Calc: threaded Changing earliest version affected accordingly. and *which* help mode do we spear of, we now have three of them, "classic" offline help, online help and offline html help ? In the case of the interaction dialog, both Helponline and Help offline (browser based) send the same HID offline URL: file:///home/tdf/git/core/instdir/program/../help/index.html?Target=simpress/modules/simpress/ui/interactiondialog/help&Language=pt-BR&System=UNIX&Version=6.5" Online URL: https://help.libreoffice.org/6.5/index.html?Target=simpress/modules/simpress/ui/interactiondialog/help&Language=pt-BR&System=UNIX&Version=6.5 In this case, HID is 'Target=' There is no Help page for HID(target) simpress/modules/simpress/ui/interactiondialog/* The target help page to open is helpcontent2/source/text/simpress/01/06070000.xhp where a bookmark is defined (among others) to <bookmark xml-lang="en-US" branch="hid/modules/simpress/ui/interactionpage/InteractionPage" id="bm_id3152874" localize="false"/> so 'Target=simpress/modules/simpress/ui/interactionpage/InteractionPage' should be in the URL instead. I think the event page doesn't work cause of missing help for the page. https://gerrit.libreoffice.org/#/c/84243/ would fix that. The interaction dialog indeed doesn't check the contents area before trying the dialog itself. https://gerrit.libreoffice.org/#/c/84245/ will try and address that Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/ccbdf9f9430127f14e9edb092385d0fcaab3b157 Related: tdf#129068 add EventConfigPage to help targets Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/help/commit/830406480085e533d5626963dd8342a512cfac82 Related: tdf#129068 add EventConfigPage to help targets Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/d4c22030d7c83de6f1835cdb5d891c2d563c34fd tdf#129068 try dialog content area help before dialog itself It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4359ee40b42a6c3febd5ff8f8286303d20d245e9 tdf#129068 try dialog content area help before dialog itself It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Hi Caolán, Oliver, should it be backported to libreoffice-6-3 branch ? |