Bug 129071

Description:
While cleaning up my mail I stumbled over bug 125921 comment 10, which was added after the bug was closed. A little quote from the comment: "I tested 6.3 ... [but] the Open/Save file dialog still shows up as "soffice.bin" and as a result creates a second entry in the taskbar when it is invoked."

For me it's not just the file picker, but also all other dialogs I could test. Doesn't matter if the are modal or not, doesn't matter if they are transient or not. This happens in LO KF5 only. Other KDE apps, like kate, won't have separate entries in the task bar for opened dialogs or file pickers. Same for the gen and gtk3 backends. Oh - and I noticed before, that there is something broken with the transient setting wrt Qt5. If one opens "About Libre Office" and clicks on the start center => not so nice flickering.

Finding the origin of this problem was a longer journey of comparing xprops of windows, reading the Xcb Qt backend and identifying (now fixed) Qt bugs and in the end drawing the right conclusions.

Long story short: the KDE task bar ignores dialogs, which are transient to a main window and grouped.

Huh - but LO qt5 sets transiency and also WM_CLIENT_LEADER, like gtk3 or gen. Yes, but Qt Xcb is a little picky for which Qt::WindowType's it will really tell the window manager about the transient state (xprop WM_TRANSIENT_FOR; if you're curious look for the little isTransient function in Qt5's source). Qt::Window is not in that list, and the dialogs I tested all have no SalFrameStyleFlags::DIALOG set. On top of it is QTBUG-46626, which I originally thought to be the problem, before actually checking kate, and were I already implemented a "non-working" fix (the fix works to set the missing WM_HINTS window group, but it doesn't fix this problem).

The other half of the story is the file picker, which just runs in application modal state, but also with no parent. I have an older patch for that too, but that needs some "dedusting".

Time for some sleep.

Steps to Reproduce:
1. Open any LO dialog, like "About LO" or the file picker


Actual Results:
The dialog shows up as a separate taskbar entry.

Expected Results:
The dialog doesn't shows up as a separate taskbar entry.


Reproducible: Always


User Profile Reset: No



Additional Info:
I didn't really check, but I guess it's broken since qt5 was added.