Bug 129134

Summary: ApplicationColors Scrolled List moves too little
Product: LibreOffice Reporter: TorrAB
Component: WriterAssignee: Caolán McNamara <caolan.mcnamara>
Status: VERIFIED FIXED    
Severity: minor CC: caolan.mcnamara, vsfoote, xiscofauli
Priority: medium Keywords: bibisected, regression
Version: 6.4.0.0.beta1+   
Hardware: All   
OS: All   
Whiteboard: target:6.5.0 target:6.4.0.1
Crash report or crash signature: Regression By:

Description TorrAB 2019-12-01 15:30:18 UTC 
Description:
Tools>Options>ApplicationColors:
LO Version: 6.3.3.2 (x64): clicking ˄˅ (up, down) on the slider moves the menu by one row; OK.
LO Version: 6.4.0.0.beta1 (x64): clicking ˄˅ moves the menu very little; why?.***

Steps to Reproduce:
1.Tools>Options>ApplicationColors:
2.up, down on the slider
3.

Actual Results:
tiny movement

Expected Results:
jump by one row


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 V Stuart Foote 2019-12-01 20:21:24 UTC 
Confirming effect on current master/6.5.0alpha0+ as compared to 6.3.3.2, but not clear it is unintended. The UI was welded at 6.4.0 [1]

Before a mouse click on the down or up arrow would move by one attribute, while a click in the scrollbar would move by one panel window--correct for the GUI.

At 6.4.0 and current master, the movement of scroll actions is reduced to more typical action for a scroll bar, but maybe not correct for this UI? With the welded conrol does it have to be the generic behavior?

@Caolán?

=-ref-=
[1] https://gerrit.libreoffice.org/#/c/79225/
Comment 2 Xisco Faulí 2019-12-02 16:08:16 UTC 
(In reply to V Stuart Foote from comment #1)
> =-ref-=
> [1] https://gerrit.libreoffice.org/#/c/79225/

After that commit, the scrollbar didn't work at all. Later, it was fixed at

https://cgit.freedesktop.org/libreoffice/core/commit/?id=94d6fa11d086187b82adf9aa596e0f334827e095

when the issue reported here is already happening
Comment 3 Commit Notification 2019-12-03 08:57:24 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c5fc7dd4475d21abdfc9663c3ac55cce319c299d

tdf#129134 ApplicationColors Scrolled List moves too little

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2019-12-03 12:02:54 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/23ad16498adf24af7cc6fba243f1593147b65891

tdf#129134 ApplicationColors Scrolled List moves too little

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2019-12-04 15:30:55 UTC 
Verified in

Version: 6.5.0.0.alpha0+
Build ID: 8f7010eb47119a2428b77f5d79fc8577d9914958
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán McNamara, thanks for fixing this issue!