Bug 129374

Summary:	Dialog containing shapes is too big and doesn't scroll on iOS 4.2
Product:	LibreOffice	Reporter:	Nicolas Christener <contact>
Component:	iOS Editor	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tml
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	iOS
Whiteboard:	target:6.5.0
Crash report or crash signature:		Regression By:
Attachments:	Printscreen showing the issue

Description Nicolas Christener 2019-12-13 15:44:15 UTC

Description:
The dialog with the shapre selection is too big and doesn't fit on the screen. Furthermore there is no possiblity to scroll in the dialog.

Steps to Reproduce:
1. Create/open a writer document in iOS 4.2
2. Click the "Shape" button in the menu bar

Actual Results:
The dialog containing all shapes doesn't fit onto the screen

Expected Results:
The dialog should fit on the screen (maybe by using a scrollbar?).


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested on 4.2 (25) with iOS 13.3.x

Comment 1 Nicolas Christener 2019-12-13 15:44:50 UTC

Created attachment 156559 [details]
Printscreen showing the issue

Comment 2 Xisco Faulí 2019-12-16 18:37:16 UTC

Moving to NEW

Comment 3 How can I remove my account? 2020-01-07 08:35:29 UTC

Happens in web-based normal Online, too, if the display is small enough

Comment 4 How can I remove my account? 2020-01-07 09:50:20 UTC

Suggested horrible fix in https://gerrit.libreoffice.org/c/online/+/86328

Comment 5 Commit Notification 2020-01-07 10:29:29 UTC

Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/ce7ad16087701adf9803f2dfd3b2da0eb2718668

tdf#129374: Make the overlay wider on iOS if it seems necessary

Comment 6 How can I remove my account? 2020-01-07 11:04:39 UTC

(That fix is of course just a workaround; a real fix would be to make the thing with the shapes 1) automatically resize (within some sane limits) as items are added), and 2) be scrollable if there still are too many items that they don't all show up at the same time. But sadly that w2ui thing is rather opaque.)

Comment 7 Commit Notification 2020-01-08 14:31:04 UTC

Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/152a20df3a58fc79e79d6baa6a50e755ad3faae2

Revert "tdf#129374: Make the overlay wider on iOS if it seems necessary"

Comment 8 Nicolas Christener 2020-01-14 12:20:12 UTC

Hi Tor

Not sure if you consider this fixed, but it looks okay on my iPad on 4.2 (29).

Do you expect a "better" fix and we leave this issue open until then?

Comment 9 How can I remove my account? 2020-01-14 12:22:07 UTC

I would say this is fixed, yes.