| Summary: | Calc: cannot format whole row of unprotected cells since LO 6.3 | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | adirt <libof> |
| Component: | Calc | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | jokrebel, libof, noelgrandin, raal, romrodz77, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.3.3.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=133327 | ||
| Whiteboard: | target:6.5.0 target:6.4.0 target:6.3.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
calc document all is protect (no password needed) exept line 2
wrong behavior calc-6.3.4.2 right behaviour calc 6.2.8.2 cellProtection_for_row_2_with_LO_Version6.3.4.2_after_reopening |
||
|
Description
adirt
2019-12-13 19:49:21 UTC
Created attachment 156574 [details]
calc document all is protect (no password needed) exept line 2
Created attachment 156575 [details]
wrong behavior calc-6.3.4.2
Created attachment 156576 [details]
right behaviour calc 6.2.8.2
Same results here with: Windows 10 64bit and Libre Office Version 6.3.4 just downloaded from https://de.libreoffice.org/download/download/ and same problem exists with: Ubuntu Linux 20.04 and Libre Office Version 6.3.3.2 "Cell format" then has for row 2 not nothing or ticks for blocked, but a dash (in the other selectable fields too) Created attachment 156579 [details]
cellProtection_for_row_2_with_LO_Version6.3.4.2_after_reopening
Problem too with Version: 6.3.4.2 at Linux
Shouldn't there
(see Picture cellProtection_for_row_2_with_LO_Version6.3.4.2_after_reopening)
normaly only "nothing" or "a hook" beeing able
sorry for my bad english
This seems to have begun at the below commit. Adding Cc: to Noel Grandin; Could you possibly take a look at this one? Thanks /bibisect-win32-6.3 9f92d23718acb19aeda0f4b4cfa43cd4d3bad8e5 is the first bad commit commit 9f92d23718acb19aeda0f4b4cfa43cd4d3bad8e5 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Sat May 18 03:32:15 2019 -0700 source 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 author Noel Grandin <noel.grandin@collabora.co.uk> 2019-05-15 15:35:51 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2019-05-18 10:46:12 +0200 commit 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 (patch) tree 1ff5fdaa95d21f7cdd4e97257adf170b2c98347c parent e7ace9a5fa71bd722e7637285a22715729b620d1 (diff) tdf#125254 Performance: A spreadsheet opens too slow, part2 raal, are you sure about this bibisect? I can't see how that commit could cause this. (In reply to Noel Grandin from comment #7) > raal, are you sure about this bibisect? I can't see how that commit could > cause this. Hi Noel,checked again with bibisect-win32-6.3 $ git checkout -f 9f92d23718acb19aeda0f4b4cfa43cd4d3bad8e5 --> bug is here $ git checkout HEAD~1 --> bug is not here git log 9f92d23718acb19aeda0f4b4cfa43cd4d3bad8e5 commit 9f92d23718acb19aeda0f4b4cfa43cd4d3bad8e5 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Sat May 18 03:32:15 2019 -0700 source 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 Looks like bug is in your commit. Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bf17db716f4ecaf28c2a0797bf90c9b0731015d6 tdf#129393 Calc: cannot format whole row of unprotected cells It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. thanks raal Verified in Version: 6.5.0.0.alpha0+ Build ID: 69a377c37b234b9b609045dbf40c40e0adc0a0b4 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Noel, thanks for fixing this issue!! Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/c21b6629a8af2b4d87840fcee8d39b3f77f08c98 tdf#129393 Calc: cannot format whole row of unprotected cells It will be available in 6.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/22432848e99fddca20168f7637bbf3c579eea601 tdf#129393 Calc: cannot format whole row of unprotected cells It will be available in 6.3.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I've tried to create a UItest for this but the UItest frameworks has problems to deal with errormessages, I don't know how to test it atm Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-4-0": https://git.libreoffice.org/core/commit/7dab34bc494e5b03537105cff385aa880968d9c8 tdf#129393 Calc: cannot format whole row of unprotected cells It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 130132 has been marked as a duplicate of this bug. *** Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1332a16f42c47f377a29cb53c17704a449235664 tdf#130132, tdf#129393: Add unittest It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |